Skip to content

Fix mp4 parsing regression #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

Fix mp4 parsing regression #7247

merged 1 commit into from
May 17, 2025

Conversation

robwalch
Copy link
Collaborator

This PR will...

Fix mp4 parsing regression introduced into development with #7199

Why is this Pull Request needed?

Fixes streaming of full segments in MUX Low-Latency HLS asset. config: "lowLatencyMode": false:

https://hlsjs-dev.video-dev.org/demo/?src=https%3A%2F%2Fstream.mux.com%2Fv69RSHhFelSm4701snP22dYz2jICy4E4FUyk02rW4gxRM.m3u8&demoConfig=eyJlbmFibGVTdHJlYW1pbmciOnRydWUsImF1dG9SZWNvdmVyRXJyb3IiOmZhbHNlLCJzdG9wT25TdGFsbCI6ZmFsc2UsImR1bXBmTVA0IjpmYWxzZSwibGV2ZWxDYXBwaW5nIjotMSwibGltaXRNZXRyaWNzIjotMX0=

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

(Fixes streaming of full segments in MUX Low-Latency HLS asset. config: `"lowLatencyMode": false`)
@robwalch robwalch added this to the 1.6.3 milestone May 16, 2025
@robwalch robwalch merged commit 084b502 into master May 17, 2025
16 checks passed
@robwalch robwalch deleted the bugfix/mp4-video-sample-data branch May 17, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant