Skip to content

Prevent overlapping track appends in muxed fmp4 on discontinuity #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Apr 26, 2025

This PR will...

  • Parse fmp4 truns to find audio and video base time and sample durations in one place
  • Detect missing sync sample at start of fmp4 and error for switch or backtracking
  • Use the same track for timestamp offsets with muxed mp4 (base initPTS on audio or video, whichever has the earliest sample times)
  • Jump gaps in muxed audio video buffer on stall as long as the gap does not traverse more than one segment boundary
  • Ensure that EoS is signaled only once the playhead is in the last buffered range

Why is this Pull Request needed?

Prevents decode errors cause by overlapping appends

Are there any points in the code the reviewer needs to double check?

Resolves issues:

#7114 (where pipeline error is a result of overlapping appends, not where platform decode error is unavoidable)

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch force-pushed the bugfix/muxed-fmp4-overlapping-appends-on-discontinuity branch from 0c5d163 to abe4557 Compare May 3, 2025 02:12
@robwalch robwalch added this to the 1.6.3 milestone May 3, 2025
@robwalch robwalch force-pushed the bugfix/muxed-fmp4-overlapping-appends-on-discontinuity branch from abe4557 to cf5ce0d Compare May 5, 2025 20:18
@robwalch robwalch merged commit fcd4a36 into master May 5, 2025
16 checks passed
@robwalch robwalch deleted the bugfix/muxed-fmp4-overlapping-appends-on-discontinuity branch May 5, 2025 22:11
robwalch added a commit that referenced this pull request May 16, 2025
(Fixes streaming of full segments in MUX Low-Latency HLS asset. config: `"lowLatencyMode": false`)
@robwalch robwalch mentioned this pull request May 16, 2025
3 tasks
robwalch added a commit that referenced this pull request May 17, 2025
(Fixes streaming of full segments in MUX Low-Latency HLS asset. config: `"lowLatencyMode": false`)
robwalch added a commit that referenced this pull request May 30, 2025
robwalch added a commit that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant