Skip to content

Conversation

lvnam96
Copy link
Contributor

@lvnam96 lvnam96 commented May 18, 2023

This PR will:

Correcting usage of extended generic type LoaderContext in type Loader

Why is this Pull Request needed?

Better typing when submmiting custom loaders into HLS instance.

Are there any points in the code the reviewer needs to double check?

No

Resolves issues:

#5487

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@lvnam96 lvnam96 force-pushed the bugfix/correct-context-loader-type branch from 1c6d30c to 075e834 Compare June 7, 2023 08:33
@lvnam96
Copy link
Contributor Author

lvnam96 commented Jun 7, 2023

@robwalch can you have a quick look at this PR?

@robwalch robwalch added this to the 1.5.0 milestone Jun 7, 2023
@robwalch robwalch merged commit 557cf79 into video-dev:master Jun 7, 2023
robwalch added a commit that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants