-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Description
This change seems to result in some unfortunate behavior. It results in near immediate fatal error in case of an intermittent failure (like mobile on the train, but it could occur for a great many reasons), skipping the normal logic where it tries the next segment and by and large merrily proceeds with playback. I think status 0 should be treated identically to 404 just as before, since this touches the very core of the dependability of HLS.
I'm not convinced the HTTP status 0 should be treated any differently than regular 404 at all, but if we assume it should, I think it should be in the form of a more aggressive back-off or some such rather than as completely different behavior.
The intended behavior can probably be achieved better with navigator.onLine
and the offline
and online
events.
https://developer.mozilla.org/en-US/docs/Web/API/Window/offline_event
https://developer.mozilla.org/en-US/docs/Web/API/Window/online_event
Originally posted by @Frenzie in #7464 (comment)
The illustration is a bit artificial, but I believe it illustrates the general problem well enough.
In 1.6.9 the CORS/network error is treated the same as 404 and playback continues, in 1.6.10 it gets stuck forever.
1.6.9 (no problem)
1.6.10 (gets stuck)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status