Skip to content

Defer segment requests when network connection is lost #7476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 22, 2025
Merged

Defer segment requests when network connection is lost #7476

merged 5 commits into from
Aug 22, 2025
+65 −45

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 21, 2025 •
edited
Loading

This PR will...

Why is this Pull Request needed?

Avoid fatal error and unnecessary retries when offline (temporarily).
Allow skipping of blocked segments in live, but not in VOD where all content should be expected to load eventually.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #7471

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch
Defer segment requests until "online" event after network error with …
9656354 
…"offline" state

Fixes #7471
Only treat no alternal segment request failures as gaps in live playlists
Follow up to #7464, #7410
@robwalch robwalch added this to the 1.6.11 milestone Aug 21, 2025
@robwalch robwalch mentioned this pull request Aug 21, 2025
Closed
@robwalch
Retry once per seeking event (even when offline)
ba052a6 
Do not exhaust retries in tick loop while seeking
Only schedule immediate tick on seeking when buffer is empty and state is idle
#7472
@robwalch
Use polling to handle waiting to retry while offline (Firefox)
4c7c110 
#7471 (comment)
@robwalch
Remove unused this.onOnline reference
f2ce64b
@robwalch
Review cleanup
f677593
@robwalch robwalch merged commit b2d7391 into master Aug 22, 2025
16 checks passed
@robwalch robwalch deleted the enhancement/handle-offline-treat-live-no-alt-as-gap branch August 22, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
HLS.js Release Planning and Backlog
Archived in project
Milestone
1.6.11
Development

Successfully merging this pull request may close these issues.

Regression due to treating HTTP status 0 differently from 404
1 participant
@robwalch