Allow for dropped updates in the benchmarks #4691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
sokra
approved these changes
Apr 25, 2023
sokra
reviewed
Apr 25, 2023
crates/turbopack-bench/src/lib.rs
Outdated
Comment on lines
39
to
43
| /// The maximum amount of time to wait for HMR during the actual benchmark. This | ||
| /// is a lot shorter than the init timeout because we expect updates to | ||
| /// generally happen quickly, and we don't want to wait for a long time when an | ||
| /// update is dropped. | ||
| const MAX_UPDATE_TIMEOUT: Duration = Duration::from_secs(5); |
There was a problem hiding this comment.
Isn't that a bit too short for 30k modules with e. g. webpack?
Maybe we can scale the number by number of modules?
There was a problem hiding this comment.
Indeed, I forgot just how slow these were. The issue with having too high a number here is that it considerably slows down benchmarks when updates are, in fact, dropped. Perhaps this timeout should be variable, or exponential.
dbba87d to
67d9209
Compare
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This improves the reliability of HMR benchmarks for bundlers that can drop updates (Vite, Turbopack). Before, an update being dropped meant the whole benchmark was canceled. ### Testing Instructions Running the benchmarks
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This improves the reliability of HMR benchmarks for bundlers that can drop updates (Vite, Turbopack). Before, an update being dropped meant the whole benchmark was canceled. ### Testing Instructions Running the benchmarks
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This improves the reliability of HMR benchmarks for bundlers that can drop updates (Vite, Turbopack). Before, an update being dropped meant the whole benchmark was canceled. ### Testing Instructions Running the benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the reliability of HMR benchmarks for bundlers that can drop updates (Vite, Turbopack). Before, an update being dropped meant the whole benchmark was canceled.
Testing Instructions
Running the benchmarks