Skip to content

Conversation

ugur-vaadin
Copy link
Contributor

Description

It is possible that changing sheets with custom editors cause the map currentCellKeysToEditorIdMap to not be updated in time under heavy load. This causes a NPE since the check for whether the map is null is done after copying the map. This PR does not change the underlying mechanism, but fixes the logic of checking for a null map.

The related issue should not be closed, but should be debugged further and verified whether a fix is needed.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@ugur-vaadin ugur-vaadin marked this pull request as ready for review August 19, 2025 06:33
@ugur-vaadin ugur-vaadin force-pushed the fix-copy-cell-keys-to-editor-id-map-only-if-not-null branch from c4fc1b6 to 850c1a6 Compare August 19, 2025 08:27
@ugur-vaadin ugur-vaadin enabled auto-merge (squash) August 19, 2025 08:27
Copy link

@ugur-vaadin ugur-vaadin merged commit e64c042 into main Aug 19, 2025
5 checks passed
@ugur-vaadin ugur-vaadin deleted the fix-copy-cell-keys-to-editor-id-map-only-if-not-null branch August 19, 2025 09:35
sissbruecker pushed a commit that referenced this pull request Aug 19, 2025
Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
sissbruecker pushed a commit that referenced this pull request Aug 19, 2025
Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants