fix: copy cell keys to editor id map only if not null #7857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible that changing sheets with custom editors cause the map
currentCellKeysToEditorIdMap
to not be updated in time under heavy load. This causes a NPE since the check for whether the map is null is done after copying the map. This PR does not change the underlying mechanism, but fixes the logic of checking for a null map.The related issue should not be closed, but should be debugged further and verified whether a fix is needed.
Type of change
Checklist