fix: determine whether a cell is locked on the fly #7847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
157bd7b to
29dda3c
Compare
052e7c7 to
40fcc8a
Compare
40fcc8a to
ec1d10f
Compare
.../src/test/java/com/vaadin/flow/component/spreadsheet/test/LockedCellsWithCustomEditorIT.java
Show resolved
Hide resolved
DiegoCardoso
approved these changes
Aug 18, 2025
ec1d10f to
b6a5af9
Compare
…ttps://github.com/vaadin/flow-components into fix-determine-whether-a-cell-is-locked-on-the-fly
|
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
* fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * test: add horizontal its and cleanup test page
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
* fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * test: add horizontal its and cleanup test page
sissbruecker
pushed a commit
that referenced
this pull request
Aug 19, 2025
* fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * test: add horizontal its and cleanup test page Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
sissbruecker
pushed a commit
that referenced
this pull request
Aug 19, 2025
* fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * fix: determine whether a cell is locked on the fly * fix: add missing cell locked checks * chore: merge if blocks * test: add its for navigating to custom editors * test: add horizontal its and cleanup test page Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the extra layer of state management regarding whether the current cell is locked and makes it so that it is retrieved on the fly. It is prone to timing issues and adds complexity without any real benefit.
Fixes #7653
Type of change
Checklist