feat: menu bar test bench improvements #7807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Aug 8, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds several improvements to the menu bar TestBench elements to align them with how the context menu elements work:
MenuBarSubMenuElementto represent an opened submenu, with the same API asContextMenuElementMenuBarButtonElement.openSubMenu()to open the menu for a button and return it. Throws if no menu was opened for this button.MenuBarItemElement.openSubMenu()to open the menu for a menu item and return it. Throws if no menu was opened for this item.Also deprecates a number of APIs:
MenuBarButtonElement.getSubMenuItems()- items can be retrieved through the submenu returned fromopenSubMenu()orgetSubMenu()MenuBarItemElement.getSubMenuItems()- items can be retrieved through the submenu returned fromopenSubMenu()orgetSubMenu()MenuBarElement.getSubMenuItems()- open a submenu for a button instead and get the items from thatMenuBarElement.getSubMenuItems(TestBenchElement subMenu)- open a submenu for a button or item instead and get the items from thatMenuBarElement.getSubMenu()- open a submenu for a button insteadMenuBarElement.getSubMenus()- open submenus through buttons or items instead and use the references returned from thoseRelated to #7801, #7520
Type of change