feat!: context menu test bench improvements #7801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Aug 6, 2025
| */ | ||
| @Element("vaadin-context-menu-overlay") | ||
| @Element("vaadin-context-menu") |
There was a problem hiding this comment.
I wonder if we should just remove ContextMenuOverlayElement completely? It was added quite recently.
There was a problem hiding this comment.
That was my intention as well, but since it was so easy to keep it working I thought why not keep it. We probably won't have to touch it again until we remove it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the TestBench API for
ContextMenu:ContextMenuElement.openByRightClick()to wait for a menu to open and return it. Throws an exception if no menu opens (behavior change).ContextMenuElement.getMenuItems()to get all items from a menuContextMenuElement.getMenuItem(string)to find an item by textContextMenuElement.waitUntilClosed()to wait until a context menu has finished closing. Throws an exception if the menu does not closeContextMenuItemElement.openSubMenu()to wait for a submenu to open and return it. Throws an exception if no menu opens (behavior change).Also deprecates
ContextMenuOverlayElement. The class is now a proxy toContextMenuElementand should thus keep working as before.Fixes #7520
Type of change