feat: control manually when CustomField updates value #7771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevaadinman
reviewed
Aug 6, 2025
...aadin-custom-field-flow/src/main/java/com/vaadin/flow/component/customfield/CustomField.java
Outdated
Show resolved
Hide resolved
|
Very nice improvement, I have missed this feature myself. I'd consider thought adding a constructor that allows you to bypass this "handy" (or "surprising" as I might call it) feature. |
sissbruecker
approved these changes
Aug 11, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Add disableUpdateValueOnChange to the CustomField * Add disableUpdateValueOnChange to the CustomField * Fix Sonar issues * Fix Sonar issues * feat: Add manualValueChangeTriggering in the CustomField * improve naming, javadoc * replace IT with unit test --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker
added a commit
that referenced
this pull request
Aug 11, 2025
* Add disableUpdateValueOnChange to the CustomField * Add disableUpdateValueOnChange to the CustomField * Fix Sonar issues * Fix Sonar issues * feat: Add manualValueChangeTriggering in the CustomField * improve naming, javadoc * replace IT with unit test --------- Co-authored-by: Jean-Christophe Gueriaud <51313578+jcgueriaud1@users.noreply.github.com> Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.
Fixes #7108 (issue)
Type of change
Checklist
Additional for
Featuretype of change