fix: adjust MenuBarElement and ITs to pass with native popover #7779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Aug 1, 2025
...gration-tests/src/test/java/com/vaadin/flow/component/menubar/tests/MenuBarClassNamesIT.java
Outdated
Show resolved
Hide resolved
...-bar-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarElement.java
Outdated
Show resolved
Hide resolved
...-bar-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarElement.java
Outdated
Show resolved
Hide resolved
...-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarItemElement.java
Outdated
Show resolved
Hide resolved
sissbruecker
reviewed
Aug 1, 2025
...-integration-tests/src/test/java/com/vaadin/flow/component/menubar/tests/MenuBarThemeIT.java
Outdated
Show resolved
Hide resolved
...-integration-tests/src/test/java/com/vaadin/flow/component/menubar/tests/MenuBarThemeIT.java
Outdated
Show resolved
Hide resolved
|
914e873
into
flow-components-update-npmpackages-webjars-versions-main-1754044715
3 of 5 checks passed
web-padawan
added a commit
that referenced
this pull request
Aug 4, 2025
* chore: Update NpmPackages Webjars versions (main) * chore: update dialog ITs (#7777) * chore: update context menu ITs (#7778) * chore: update crud dialog ITs (#7750) * fix: adjust MenuBarElement and ITs to pass with native popover (#7779) * fix: adjust ComboBox and MultiSelectComboBox ITs to pass with native popover (#7780) * fix: adjust LoginOverlay logic, TestBench and ITs for native popover (#7781) * update grid context menu ITs --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted MenuBar TestBench and ITs to the web component changes.
Type of change