Skip to content

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jul 8, 2025

Description

The PR updates Lumo imports to load CSS files instead of JS files.

Warning

Do not merge until all components have new base styles.

Part of vaadin/web-components#9082

Type of change

  • Refactor

@vursen vursen changed the title refactor: switch Lumo imports from JS to CSS files refactor: switch Lumo from JS to CSS files Jul 8, 2025
@vursen vursen requested a review from web-padawan July 8, 2025 13:33
Copy link

sonarqubecloud bot commented Aug 6, 2025

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with web components main branch and it seems to work.

@web-padawan web-padawan removed the request for review from DiegoCardoso August 6, 2025 12:54
@web-padawan web-padawan merged commit 3fb0410 into main Aug 6, 2025
5 checks passed
@web-padawan web-padawan deleted the load-lumo-css-version branch August 6, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants