Skip to content

feat: Add HasClearButton mixin to TestBench elements #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 12, 2025
Merged

feat: Add HasClearButton mixin to TestBench elements #7337

merged 9 commits into from
May 12, 2025

Conversation

mshabarov
Copy link
Contributor

Description

Adds a helper interface to TestBench elements having clear button.
A second part for vaadin/testbench#1902 and vaadin/testbench#1903.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mshabarov mshabarov marked this pull request as ready for review May 9, 2025 13:53
@mshabarov mshabarov requested a review from TatuLund May 9, 2025 13:54
@mshabarov mshabarov requested a review from TatuLund May 12, 2025 08:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TatuLund TatuLund merged commit 2c76563 into main May 12, 2025
5 checks passed
@TatuLund TatuLund deleted the add-has-clear-button-mixin branch May 12, 2025 10:40
@vaadin-bot
Copy link
Collaborator

Hi @mshabarov and @TatuLund, when i performed cherry-pick to this commit to 23.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 2c76563
error: could not apply 2c76563... feat: Add HasClearButton mixin to TestBench elements (#7337)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mshabarov added a commit that referenced this pull request May 14, 2025
@mshabarov
feat: Add HasClearButton mixin to TestBench elements (#7337)
8a73cb5 
---------
Co-authored-by: Tatu Lund <tatu@vaadin.com>

(cherry picked from commit 2c76563)
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.8.0.alpha7 and is also targeting the upcoming stable 24.8.0 version.

mshabarov added a commit that referenced this pull request May 16, 2025
@mshabarov
feat: Add HasClearButton mixin to TestBench elements (#7337)
5f0fc95 
---------
Co-authored-by: Tatu Lund <tatu@vaadin.com>

(cherry picked from commit 2c76563)
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.6.0.alpha1 and is also targeting the upcoming stable 23.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TatuLund TatuLund TatuLund approved these changes

Assignees
No one assigned
Labels
need to pick manually 23.6 prerelease version for Vaadin 23.6.0 prerelease version for Vaadin 24.8.0 Released with Vaadin 23.6.0.alpha1 Released with Vaadin 24.8.0.alpha7 target/23.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshabarov @vaadin-bot @TatuLund