refactor!: remove setOverlayClassName from overlay components (#7813)

sissbruecker · web-flow · commit e2ff06fdedd1 · 2025-08-08T14:44:30.000+03:00
diff --git a/vaadin-avatar-flow-parent/vaadin-avatar-flow/src/main/java/com/vaadin/flow/component/avatar/AvatarGroup.java b/vaadin-avatar-flow-parent/vaadin-avatar-flow/src/main/java/com/vaadin/flow/component/avatar/AvatarGroup.java
@@ -37,7 +37,6 @@
 import com.vaadin.flow.component.UI;
 import com.vaadin.flow.component.dependency.JsModule;
 import com.vaadin.flow.component.dependency.NpmPackage;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasThemeVariant;
 import com.vaadin.flow.internal.JsonSerializer;
 import com.vaadin.flow.internal.NodeOwner;
@@ -70,8 +69,8 @@
 @Tag("vaadin-avatar-group")
 @JsModule("@vaadin/avatar-group/src/vaadin-avatar-group.js")
 @NpmPackage(value = "@vaadin/avatar-group", version = "25.0.0-alpha12")
-public class AvatarGroup extends Component implements HasOverlayClassName,
-        HasStyle, HasSize, HasThemeVariant<AvatarGroupVariant> {
+public class AvatarGroup extends Component
+        implements HasStyle, HasSize, HasThemeVariant<AvatarGroupVariant> {
 
     /**
      * Item to be set as an avatar for the avatar group.
diff --git a/vaadin-avatar-flow-parent/vaadin-avatar-flow/src/test/java/com/vaadin/flow/component/avatar/tests/AvatarGroupTest.java b/vaadin-avatar-flow-parent/vaadin-avatar-flow/src/test/java/com/vaadin/flow/component/avatar/tests/AvatarGroupTest.java
@@ -26,7 +26,6 @@
 import com.vaadin.flow.component.avatar.AvatarGroup.AvatarGroupItem;
 import com.vaadin.flow.component.avatar.AvatarGroupVariant;
 import com.vaadin.flow.component.avatar.AvatarVariant;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 
 public class AvatarGroupTest {
 
@@ -166,11 +165,4 @@ public void setI18n() {
         avatarGroup.setI18n(i18n);
         Assert.assertEquals(i18n, avatarGroup.getI18n());
     }
-
-    @Test
-    public void implementsHasOverlayClassName() {
-        Assert.assertTrue("AvatarGroup should support overlay class name",
-                HasOverlayClassName.class
-                        .isAssignableFrom(new AvatarGroup().getClass()));
-    }
 }
diff --git a/vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBoxBase.java b/vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBoxBase.java
@@ -49,7 +49,6 @@
 import com.vaadin.flow.component.shared.HasAllowedCharPattern;
 import com.vaadin.flow.component.shared.HasAutoOpen;
 import com.vaadin.flow.component.shared.HasClearButton;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasValidationProperties;
 import com.vaadin.flow.component.shared.InputField;
 import com.vaadin.flow.component.shared.ValidationUtil;
@@ -91,10 +90,9 @@
  *            Type of the selection / value of the extending component
  */
 public abstract class ComboBoxBase<TComponent extends ComboBoxBase<TComponent, TItem, TValue>, TItem, TValue>
-        extends AbstractSinglePropertyField<TComponent, TValue>
-        implements Focusable<TComponent>, HasAllowedCharPattern, HasAriaLabel,
-        HasAutoOpen, HasClearButton, HasOverlayClassName,
-        HasDataView<TItem, String, ComboBoxDataView<TItem>>,
+        extends AbstractSinglePropertyField<TComponent, TValue> implements
+        Focusable<TComponent>, HasAllowedCharPattern, HasAriaLabel, HasAutoOpen,
+        HasClearButton, HasDataView<TItem, String, ComboBoxDataView<TItem>>,
         InputField<AbstractField.ComponentValueChangeEvent<TComponent, TValue>, TValue>,
         HasLazyDataView<TItem, String, ComboBoxLazyDataView<TItem>>,
         HasListDataView<TItem, ComboBoxListDataView<TItem>>, HasTheme,
diff --git a/vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/test/java/com/vaadin/flow/component/combobox/ComboBoxBaseTest.java b/vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/test/java/com/vaadin/flow/component/combobox/ComboBoxBaseTest.java
@@ -30,7 +30,6 @@
 import com.vaadin.flow.component.UI;
 import com.vaadin.flow.component.combobox.dataview.ComboBoxListDataView;
 import com.vaadin.flow.component.shared.HasAllowedCharPattern;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasTooltip;
 import com.vaadin.flow.data.provider.AbstractDataProvider;
 import com.vaadin.flow.data.provider.DataCommunicator;
@@ -81,13 +80,6 @@ public void implementsHasAllowedCharPattern() {
                         createComboBox(String.class).getClass()));
     }
 
-    @Test
-    public void implementsHasOverlayClassName() {
-        Assert.assertTrue("ComboBox should support overlay class name",
-                HasOverlayClassName.class.isAssignableFrom(
-                        createComboBox(String.class).getClass()));
-    }
-
     @Test
     public void implementsHasTooltip() {
         Assert.assertTrue("ComboBox should support setting a tooltip",
diff --git a/vaadin-context-menu-flow-parent/vaadin-context-menu-flow/src/main/java/com/vaadin/flow/component/contextmenu/ContextMenu.java b/vaadin-context-menu-flow-parent/vaadin-context-menu-flow/src/main/java/com/vaadin/flow/component/contextmenu/ContextMenu.java
@@ -18,7 +18,6 @@
 import com.vaadin.flow.component.ClickEvent;
 import com.vaadin.flow.component.Component;
 import com.vaadin.flow.component.ComponentEventListener;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.function.SerializableRunnable;
 
 /**
@@ -49,7 +48,7 @@
  */
 @SuppressWarnings("serial")
 public class ContextMenu extends ContextMenuBase<ContextMenu, MenuItem, SubMenu>
-        implements HasMenuItems, HasOverlayClassName {
+        implements HasMenuItems {
 
     /**
      * Creates an empty context menu.
diff --git a/vaadin-context-menu-flow-parent/vaadin-context-menu-flow/src/test/java/com/vaadin/flow/component/contextmenu/ContextMenuTest.java b/vaadin-context-menu-flow-parent/vaadin-context-menu-flow/src/test/java/com/vaadin/flow/component/contextmenu/ContextMenuTest.java
@@ -30,7 +30,6 @@
 import com.vaadin.flow.component.html.Div;
 import com.vaadin.flow.component.html.NativeButton;
 import com.vaadin.flow.component.html.Span;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 
 /**
  * Unit tests for the ContextMenu.
@@ -216,13 +215,6 @@ public void serializeContextMenu() throws IOException {
         out.writeObject(menu);
     }
 
-    @Test
-    public void implementsHasOverlayClassName() {
-        Assert.assertTrue("ContextMenu should support overlay class name",
-                HasOverlayClassName.class
-                        .isAssignableFrom(new ContextMenu().getClass()));
-    }
-
     private void addDivAtIndex(int index) {
         ContextMenu contextMenu = new ContextMenu();
 
diff --git a/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java b/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java
@@ -47,7 +47,6 @@
 import com.vaadin.flow.component.shared.HasAllowedCharPattern;
 import com.vaadin.flow.component.shared.HasAutoOpen;
 import com.vaadin.flow.component.shared.HasClearButton;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasPrefix;
 import com.vaadin.flow.component.shared.HasThemeVariant;
 import com.vaadin.flow.component.shared.HasValidationProperties;
@@ -135,8 +134,8 @@ public class DatePicker
         implements Focusable<DatePicker>, HasAllowedCharPattern, HasAriaLabel,
         HasAutoOpen, HasClearButton,
         InputField<AbstractField.ComponentValueChangeEvent<DatePicker, LocalDate>, LocalDate>,
-        HasOverlayClassName, HasPrefix, HasThemeVariant<DatePickerVariant>,
-        HasValidationProperties, HasValidator<LocalDate>, HasPlaceholder {
+        HasPrefix, HasThemeVariant<DatePickerVariant>, HasValidationProperties,
+        HasValidator<LocalDate>, HasPlaceholder {
 
     private DatePickerI18n i18n;
 
diff --git a/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java b/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java
@@ -33,7 +33,6 @@
 import com.vaadin.flow.component.UI;
 import com.vaadin.flow.component.datepicker.DatePicker.DatePickerI18n;
 import com.vaadin.flow.component.shared.HasAllowedCharPattern;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasTooltip;
 import com.vaadin.flow.component.shared.InputField;
 import com.vaadin.flow.data.binder.Result;
@@ -293,13 +292,6 @@ public void implementsHasAllowedCharPattern() {
                         .isAssignableFrom(new DatePicker().getClass()));
     }
 
-    @Test
-    public void implementsHasOverlayClassName() {
-        Assert.assertTrue("DatePicker should support overlay class name",
-                HasOverlayClassName.class
-                        .isAssignableFrom(new DatePicker().getClass()));
-    }
-
     @Test
     public void implementsHasTooltip() {
         DatePicker picker = new DatePicker();
diff --git a/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow/src/main/java/com/vaadin/flow/component/datetimepicker/DateTimePicker.java b/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow/src/main/java/com/vaadin/flow/component/datetimepicker/DateTimePicker.java
@@ -34,7 +34,6 @@
 import com.vaadin.flow.component.dependency.JsModule;
 import com.vaadin.flow.component.dependency.NpmPackage;
 import com.vaadin.flow.component.shared.HasAutoOpen;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasThemeVariant;
 import com.vaadin.flow.component.shared.HasValidationProperties;
 import com.vaadin.flow.component.shared.InputField;
@@ -95,8 +94,8 @@ public class DateTimePicker
         extends AbstractSinglePropertyField<DateTimePicker, LocalDateTime>
         implements Focusable<DateTimePicker>, HasAutoOpen,
         InputField<AbstractField.ComponentValueChangeEvent<DateTimePicker, LocalDateTime>, LocalDateTime>,
-        HasOverlayClassName, HasThemeVariant<DateTimePickerVariant>,
-        HasValidationProperties, HasValidator<LocalDateTime> {
+        HasThemeVariant<DateTimePickerVariant>, HasValidationProperties,
+        HasValidator<LocalDateTime> {
 
     private final DateTimePickerDatePicker datePicker = new DateTimePickerDatePicker();
     private final DateTimePickerTimePicker timePicker = new DateTimePickerTimePicker();
diff --git a/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow/src/test/java/com/vaadin/flow/component/datetimepicker/DateTimePickerTest.java b/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow/src/test/java/com/vaadin/flow/component/datetimepicker/DateTimePickerTest.java
@@ -33,7 +33,6 @@
 import com.vaadin.flow.component.Component;
 import com.vaadin.flow.component.UI;
 import com.vaadin.flow.component.datepicker.DatePicker;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasTooltip;
 import com.vaadin.flow.component.shared.InputField;
 import com.vaadin.flow.di.Instantiator;
@@ -249,13 +248,6 @@ public void setTimeAriaLabel() {
         Assert.assertTrue(picker.getTimeAriaLabel().isEmpty());
     }
 
-    @Test
-    public void implementsHasOverlayClassName() {
-        Assert.assertTrue("DateTimePicker should support overlay class name",
-                HasOverlayClassName.class
-                        .isAssignableFrom(new DateTimePicker().getClass()));
-    }
-
     @Test
     public void implementsHasTooltip() {
         DateTimePicker picker = new DateTimePicker();
diff --git a/vaadin-flow-components-shared-parent/vaadin-flow-components-base/src/main/java/com/vaadin/flow/component/shared/HasOverlayClassName.java b/vaadin-flow-components-shared-parent/vaadin-flow-components-base/src/main/java/com/vaadin/flow/component/shared/HasOverlayClassName.java
diff --git a/vaadin-flow-components-shared-parent/vaadin-flow-components-base/src/test/java/com/vaadin/flow/component/shared/HasOverlayClassNameTest.java b/vaadin-flow-components-shared-parent/vaadin-flow-components-base/src/test/java/com/vaadin/flow/component/shared/HasOverlayClassNameTest.java
diff --git a/vaadin-menu-bar-flow-parent/vaadin-menu-bar-flow/src/main/java/com/vaadin/flow/component/menubar/MenuBar.java b/vaadin-menu-bar-flow-parent/vaadin-menu-bar-flow/src/main/java/com/vaadin/flow/component/menubar/MenuBar.java
@@ -36,7 +36,6 @@
 import com.vaadin.flow.component.contextmenu.SubMenu;
 import com.vaadin.flow.component.dependency.JsModule;
 import com.vaadin.flow.component.dependency.NpmPackage;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasThemeVariant;
 import com.vaadin.flow.component.shared.SlotUtils;
 import com.vaadin.flow.dom.Element;
@@ -59,9 +58,8 @@
 @JsModule("@vaadin/tooltip/src/vaadin-tooltip.js")
 @NpmPackage(value = "@vaadin/menu-bar", version = "25.0.0-alpha12")
 @NpmPackage(value = "@vaadin/tooltip", version = "25.0.0-alpha12")
-public class MenuBar extends Component
-        implements HasEnabled, HasMenuItems, HasOverlayClassName, HasSize,
-        HasStyle, HasThemeVariant<MenuBarVariant> {
+public class MenuBar extends Component implements HasEnabled, HasMenuItems,
+        HasSize, HasStyle, HasThemeVariant<MenuBarVariant> {
 
     private MenuManager<MenuBar, MenuItem, SubMenu> menuManager;
     private MenuItemsArrayGenerator<MenuItem> menuItemsArrayGenerator;
diff --git a/vaadin-menu-bar-flow-parent/vaadin-menu-bar-flow/src/test/java/com/vaadin/flow/component/menubar/tests/MenuBarTest.java b/vaadin-menu-bar-flow-parent/vaadin-menu-bar-flow/src/test/java/com/vaadin/flow/component/menubar/tests/MenuBarTest.java
@@ -22,7 +22,6 @@
 import com.vaadin.flow.component.contextmenu.MenuItem;
 import com.vaadin.flow.component.html.Span;
 import com.vaadin.flow.component.menubar.MenuBar;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 
 public class MenuBarTest {
 
@@ -86,13 +85,6 @@ public void setOpenOnHover_isOpenOnHover() {
         Assert.assertTrue(menuBar.isOpenOnHover());
     }
 
-    @Test
-    public void implementsHasOverlayClassName() {
-        Assert.assertTrue("ContextMenu should support overlay class name",
-                HasOverlayClassName.class
-                        .isAssignableFrom(new MenuBar().getClass()));
-    }
-
     @Test
     public void isReverseCollapseOrder() {
         Assert.assertFalse(menuBar.isReverseCollapseOrder());
diff --git a/vaadin-select-flow-parent/vaadin-select-flow/src/main/java/com/vaadin/flow/component/select/Select.java b/vaadin-select-flow-parent/vaadin-select-flow/src/main/java/com/vaadin/flow/component/select/Select.java
@@ -45,7 +45,6 @@
 import com.vaadin.flow.component.dependency.NpmPackage;
 import com.vaadin.flow.component.select.data.SelectDataView;
 import com.vaadin.flow.component.select.data.SelectListDataView;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasPrefix;
 import com.vaadin.flow.component.shared.HasThemeVariant;
 import com.vaadin.flow.component.shared.HasValidationProperties;
@@ -117,8 +116,8 @@ public class Select<T> extends AbstractSinglePropertyField<Select<T>, T>
         implements Focusable<Select<T>>, HasAriaLabel,
         HasDataView<T, Void, SelectDataView<T>>, HasItemComponents<T>,
         InputField<AbstractField.ComponentValueChangeEvent<Select<T>, T>, T>,
-        HasListDataView<T, SelectListDataView<T>>, HasOverlayClassName,
-        HasPrefix, HasThemeVariant<SelectVariant>, HasValidationProperties,
+        HasListDataView<T, SelectListDataView<T>>, HasPrefix,
+        HasThemeVariant<SelectVariant>, HasValidationProperties,
         HasValidator<T>, SingleSelect<Select<T>, T>, HasPlaceholder {
 
     public static final String LABEL_ATTRIBUTE = "label";
diff --git a/vaadin-select-flow-parent/vaadin-select-flow/src/test/java/com/vaadin/flow/component/select/SelectTest.java b/vaadin-select-flow-parent/vaadin-select-flow/src/test/java/com/vaadin/flow/component/select/SelectTest.java
@@ -42,7 +42,6 @@
 import com.vaadin.flow.component.Unit;
 import com.vaadin.flow.component.html.Span;
 import com.vaadin.flow.component.select.data.SelectListDataView;
-import com.vaadin.flow.component.shared.HasOverlayClassName;
 import com.vaadin.flow.component.shared.HasTooltip;
 import com.vaadin.flow.component.shared.InputField;
 import com.vaadin.flow.data.provider.DataProvider;
@@ -831,13 +830,6 @@ public void setItems_createsLabelValueEventAndItems() {
                 select.getElement().getProperty("label"));
     }
 
-    @Test
-    public void implementsHasOverlayClassName() {
-        Assert.assertTrue("Select should support overlay class name",
-                HasOverlayClassName.class
-                        .isAssignableFrom(new Select().getClass()));
-    }
-
     @Test
     public void implementsHasTooltip() {
         Assert.assertTrue(select instanceof HasTooltip);
diff --git a/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java b/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java
diff --git a/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java b/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java
