refactor!: remove setOverlayClassName from overlay components
#7813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Aug 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After refactoring overlay-based components to keep their overlay in the shadow root, the
setOverlayClassNameAPI will not be functional anymore, as the classes would be applied to the element in a shadow root. Instead, the regularHasStyleAPIs such assetClassNameshould now be used to target overlays for styling.The following components are affected:
AvatarGroupComboBoxContextMenuDatePickerDateTimePickerMenuBarSelectTimePickerAvatarGroupPart of vaadin/web-components#9742
Type of change