fix: make fetching data possible when virtual list is inert (#7727) (#7864)

vaadin-bot · ugur-vaadin · sissbruecker · web-flow · commit c8e37f1e1a82 · 2025-08-19T11:11:29.000+02:00
* test: extract getting items into helper class

* fix: make fetching data possible when virtual list is inert

---------

Co-authored-by: Ugur Saglam &lt;106508695+ugur-vaadin@users.noreply.github.com&gt;
Co-authored-by: Sascha Ißbrücker &lt;sissbruecker@vaadin.com&gt;
diff --git a/vaadin-virtual-list-flow-parent/vaadin-virtual-list-flow-integration-tests/src/main/java/com/vaadin/flow/component/virtuallist/tests/InertVirtualListPage.java b/vaadin-virtual-list-flow-parent/vaadin-virtual-list-flow-integration-tests/src/main/java/com/vaadin/flow/component/virtuallist/tests/InertVirtualListPage.java
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2000-2025 Vaadin Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.flow.component.virtuallist.tests;
+
+import java.util.stream.IntStream;
+
+import com.vaadin.flow.component.html.Div;
+import com.vaadin.flow.component.virtuallist.VirtualList;
+import com.vaadin.flow.dom.ElementUtil;
+import com.vaadin.flow.router.Route;
+
+@Route("vaadin-virtual-list/inert")
+public class InertVirtualListPage extends Div {
+
+    public InertVirtualListPage() {
+        var virtualList = new VirtualList<String>();
+        var items = IntStream.range(0, 10).mapToObj(i -> "Item " + i).toList();
+        virtualList.setItems(items);
+        ElementUtil.setInert(virtualList.getElement(), true);
+        add(virtualList);
+    }
+}
diff --git a/vaadin-virtual-list-flow-parent/vaadin-virtual-list-flow-integration-tests/src/test/java/com/vaadin/flow/component/virtuallist/tests/InertVirtualListIT.java b/vaadin-virtual-list-flow-parent/vaadin-virtual-list-flow-integration-tests/src/test/java/com/vaadin/flow/component/virtuallist/tests/InertVirtualListIT.java
@@ -0,0 +1,50 @@
+/*
+ * Copyright 2000-2025 Vaadin Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.flow.component.virtuallist.tests;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.openqa.selenium.By;
+
+import com.vaadin.flow.component.virtuallist.testbench.VirtualListElement;
+import com.vaadin.flow.testutil.TestPath;
+import com.vaadin.tests.AbstractComponentIT;
+
+import elemental.json.JsonType;
+
+@TestPath("vaadin-virtual-list/inert")
+public class InertVirtualListIT extends AbstractComponentIT {
+
+    private VirtualListElement virtualList;
+
+    @Before
+    public void init() {
+        open();
+        var loadingIndicator = findElement(By.className("v-loading-indicator"));
+        waitUntil(driver -> !loadingIndicator.isDisplayed());
+        virtualList = $(VirtualListElement.class).waitForFirst();
+    }
+
+    @Test
+    public void inertVirtualList_itemsAreRendered() {
+        var items = VirtualListHelpers.getItems(getDriver(), virtualList);
+        Assert.assertTrue(items.length() > 0);
+        for (var i = 0; i < items.length(); i++) {
+            Assert.assertNotEquals(JsonType.NULL, items.get(i).getType());
+        }
+    }
+}
diff --git a/vaadin-virtual-list-flow-parent/vaadin-virtual-list-flow/src/main/java/com/vaadin/flow/component/virtuallist/VirtualList.java b/vaadin-virtual-list-flow-parent/vaadin-virtual-list-flow/src/main/java/com/vaadin/flow/component/virtuallist/VirtualList.java
@@ -30,6 +30,7 @@
 import com.vaadin.flow.component.UI;
 import com.vaadin.flow.component.dependency.JsModule;
 import com.vaadin.flow.component.dependency.NpmPackage;
+import com.vaadin.flow.component.internal.AllowInert;
 import com.vaadin.flow.component.virtuallist.paging.PagelessDataCommunicator;
 import com.vaadin.flow.data.binder.HasDataProvider;
 import com.vaadin.flow.data.provider.ArrayUpdater;
@@ -303,6 +304,7 @@ public void onEnabledStateChanged(boolean enabled) {
         setRenderer(renderer);
     }
 
+    @AllowInert
     @ClientCallable(DisabledUpdateMode.ALWAYS)
     private void setViewportRange(int start, int length) {
         getDataCommunicator().setViewportRange(start, length);
