Skip to content

feat!: No default theme loaded #21730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

feat!: No default theme loaded #21730

merged 2 commits into from
Aug 7, 2025

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Jun 19, 2025 •
edited
Loading

Do not load Lumo as the
default theme if not defined.

Fixes #21606

@caalador caalador force-pushed the issues/21606 branch 3 times, most recently from 253f050 to bab7b7b Compare June 19, 2025 11:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2025 •
edited
Loading

Test Results

1 235 files  ± 0  1 235 suites  ±0   1h 12m 21s ⏱️ -59s
8 560 tests ± 0  8 504 ✅ ± 0  56 💤 ±0  0 ❌ ±0 
8 898 runs   - 66  8 833 ✅  - 66  65 💤 ±0  0 ❌ ±0 

Results for commit 92f2aac. ± Comparison against base commit dfd9d25.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
com.vaadin.flow.server.frontend.scanner.FrontendDependenciesTest ‑ defaultThemeIsLoadedForExporters
com.vaadin.flow.server.frontend.scanner.FullDependenciesScannerTest ‑ getTheme_noExplicitTheme_lumoThemeIsDiscovered
com.vaadin.flow.server.frontend.scanner.ScannerThemeTest ‑ should_defaultToLumoTheme_when_noThemeDefinedByExporter
com.vaadin.flow.server.frontend.scanner.ScannerThemeTest ‑ should_visitDefaultTheme_when_noThemeAnnotationIsGiven

com.vaadin.flow.server.frontend.scanner.FrontendDependenciesTest ‑ defaultThemeIsNotLoadedForExporters
com.vaadin.flow.server.frontend.scanner.FullDependenciesScannerTest ‑ getTheme_noExplicitTheme_noThemeIsDiscovered
com.vaadin.flow.server.frontend.scanner.ScannerThemeTest ‑ should_notFindAnyTheme_when_noThemeAnnotationIsGiven
com.vaadin.flow.server.frontend.scanner.ScannerThemeTest ‑ should_useExtendedClassTheme_when_noThemeDefinedByExporter

♻️ This comment has been updated with latest results.

@caalador caalador force-pushed the issues/21606 branch 2 times, most recently from 88103e9 to 0d6447f Compare June 19, 2025 12:04
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Jun 19, 2025
@caalador caalador force-pushed the issues/21606 branch 5 times, most recently from f76a896 to a26f45f Compare June 23, 2025 09:23
@caalador
feat!: No default theme loaded
53aa678 
Do not load Lumo as the
default theme if not defined.

Fixes #21606
@caalador caalador marked this pull request as ready for review June 23, 2025 11:38
@mshabarov mshabarov requested a review from mcollovati June 23, 2025 11:41
mcollovati
mcollovati requested changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it behaves like applying the @NoTheme annotation.
Some minor changes requested

@caalador
fix themeClassName
92f2aac 
fix test names
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mshabarov mshabarov marked this pull request as draft June 26, 2025 09:54
@mshabarov
Copy link
Contributor

Let's wait until all components are ported to CSS files, there are 4 PRs currently on review.

@vursen
Copy link
Contributor

vursen commented Jul 14, 2025

Depends on

@web-padawan
Copy link
Member

The PR for switching to Lumo CSS has been merged and the new Flow components snapshot is available.

@mshabarov mshabarov marked this pull request as ready for review August 7, 2025 07:48
@mshabarov mshabarov merged commit 1d496aa into main Aug 7, 2025
27 checks passed
@mshabarov mshabarov deleted the issues/21606 branch August 7, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
theming +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don’t load Lumo by default in V25
6 participants
@caalador @mshabarov @vursen @web-padawan @mcollovati @vaadin-bot