test: make grid-pro date-picker editor tests more reliable #10071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bd7fb4 to
402c960
Compare
|
web-padawan
commented
Aug 25, 2025
| cell = getContainerCell(grid.$.items, 0, 0); | ||
| await sendMouse({ type: 'click', position: [10, 10] }); |
There was a problem hiding this comment.
This was previously needed to close the editor opened in beforeEach of the wrapping suite.
Now when we have a separate desktop suite, this isn't needed anymore.
DiegoCardoso
approved these changes
Aug 25, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
web-padawan
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grid-pro date-picker ITs currently fail on 24.9 branch. This PR reorganizes tests to use
setViewport()better.Please review with "Hide whitespaces" option as tests are wrapped in a new suite.
Type of change