feat: add tooltip content-changed event and use it in controller #10045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
web-padawan
commented
Aug 20, 2025
| await nextFrame(); | ||
|
|
||
| spy.resetHistory(); | ||
| fire(tooltip, 'content-changed'); |
There was a problem hiding this comment.
These tests don't actually import vaadin-tooltip so we can't use its API and have to fire event manually.
web-padawan
commented
Aug 20, 2025
| @@ -669,6 +669,7 @@ export const TooltipMixin = (superClass) => | |||
| /** @private */ | |||
| __updateContent() { | |||
| this.__contentNode.textContent = typeof this.generator === 'function' ? this.generator(this.context) : this.text; | |||
| this.dispatchEvent(new CustomEvent('content-changed', { detail: { content: this.__contentNode.textContent } })); | |||
There was a problem hiding this comment.
Checking textContent after setting it to always return a string if null or undefined was set.
92b3420 to
6af088b
Compare
|
sissbruecker
approved these changes
Aug 20, 2025
web-padawan
added a commit
that referenced
this pull request
Aug 21, 2025
web-padawan
added a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #10008 - see #10008 (comment)
Added an event that can be used in
TooltipControllerto fire its own event - IMO it's ok to also keep it as public because currently there is no way to detect when tooltip text is changed without observing DOM nodes.Type of change