You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we plan to always set focus-ring on programmatic focus, I realised that FocusTrapController behavior would be inconsistent since it doesn't enforce that for native elements, such as <button>. Modified the logic accordingly.
Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 938ebc9
error: could not apply 938ebc9... refactor: use focusVisible: true in FocusTrapController focus (#10031)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #437.
As we plan to always set
focus-ringon programmatic focus, I realised thatFocusTrapControllerbehavior would be inconsistent since it doesn't enforce that for native elements, such as<button>. Modified the logic accordingly.The change is to use
focus({ focusVisible: true })supported in Firefox and Safari 18 but not in Chrome.Example in
vaadin-rich-text-editor-popup:This is a minor change but IMO it improves the UX in Firefox and Safari a bit.
Type of change