refactor: remove usage of AriaModalController from overlay #10026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Aug 19, 2025
| @@ -174,11 +174,11 @@ class RichTextEditorPopupOverlay extends PositionMixin( | |||
| } | |||
|
|
|||
| /** | |||
| * Override method from OverlayFocusMixin to use owner as modal root | |||
| * Override method from OverlayFocusMixin to use owner as focus trap root | |||
There was a problem hiding this comment.
The RTE color popup traps focus but IMO it shouldn't be considered modal.
70e384c to
6b7893c
Compare
|
sissbruecker
approved these changes
Aug 19, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usage of
aria-hiddenwas removed from all overlay based components, see following PRs:Let's remove usage of
AriaModalControllerfrom theOverlayFocusMixinfor simplicity.If in the future identify that some component needs it, it can be added there separately.
Type of change