refactor: set aria-modal and tabindex on the popover #10020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| :host(:focus) ::part(overlay) { | ||
| outline: var(--vaadin-focus-ring-width) solid var(--vaadin-focus-ring-color); |
There was a problem hiding this comment.
Something is wrong with the outline styles. In Chrome I don't see any outline. In Firefox it shows a dot:
Popover:
Confirm dialog:
There was a problem hiding this comment.
There is no outline on the overlay in Lumo so this is kind of expected. The dot was coming from the default focus outline, added outline: none to fix that. Created #10025 to fix this in other components.
|
sissbruecker
approved these changes
Aug 18, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #9759
Same as #9980 but for
vaadin-popover.aria-modal="true"on thevaadin-popoverelement whenmodaldisplay: contentstodisplay: blockfor Safari VoiceOvertabindex="0"from the overlay part to the popover element itselffocusinandfocusoutevent listeners to be set on the popoverType of change