Skip to content

feat: Add TestBenchElement#getParent #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 7, 2025
Merged

feat: Add TestBenchElement#getParent #1897

merged 16 commits into from
Apr 7, 2025

Conversation

TatuLund
Copy link
Contributor

Fixes #1887

@mshabarov mshabarov requested a review from mcollovati March 31, 2025 11:36
@mcollovati
Copy link
Contributor

PR is currently not compiling because PageObjectIT uses getId() method, introduced by #1896

mcollovati
mcollovati reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getParent() test looks a bit hidden to me.
Could we add a test for the method in BasicElementIT instead?
Also, the test should be present in both JUnit 4 and 5 modules

@TatuLund
Copy link
Contributor Author

TatuLund commented Apr 1, 2025

Could we add a test for the method in BasicElementIT instead?

It is doable, #1898 adds the needed id for that test, so lets merge that first in order to prevent merge conflicts.

mcollovati
mcollovati requested changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to PageObjectView and PageObjectIT should also be applied to the JUnit 4 integration test module.
Or removed, if the assertion is already covered in BasicElementIT

@TatuLund
Copy link
Contributor Author

TatuLund commented Apr 7, 2025

Changes to PageObjectView and PageObjectIT should also be applied to the JUnit 4 integration test module. Or removed, if the assertion is already covered in BasicElementIT

Done

@mcollovati mcollovati enabled auto-merge (squash) April 7, 2025 14:12
@mcollovati mcollovati merged commit 5aa96f0 into main Apr 7, 2025
2 checks passed
@mcollovati mcollovati deleted the fix1887 branch April 7, 2025 15:19
mshabarov pushed a commit that referenced this pull request Apr 16, 2025
@TatuLund @mshabarov
feat: Add TestBenchElement#getParent (#1897)
990061c 
Fixes #1887

(cherry picked from commit 5aa96f0)
mshabarov pushed a commit that referenced this pull request Apr 23, 2025
@TatuLund @mshabarov
feat: Add TestBenchElement#getParent (#1897)
92f0579 
Fixes #1887

(cherry picked from commit 5aa96f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TestBenchElement.getParent()
2 participants
@TatuLund @mcollovati