test(report): switch to testing report Merge instead of FromString #5216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e0bc1d to
101ce06
Compare
olblak
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #5189 I found it difficult to update the tests as it relied on the correct string indentation.
Using https://github.com/sanity-io/litter to get the objects out of the existing tests, I've converted all the
FromStringtests to.Mergetests. This made it easier to update tests.Also checked coverage and added a new Changelog scenarios where the new and old report have more items respectively.
Also added a test for
ToActionsStringas a part of existing test ensuring the object round trips.Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement