feat(autodiscovery): add support for k8s initContainers (#4569) #4570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks for the pullrequest. It's a really nice improvement. |
|
@luilegeant I opened luilegeant#1 on your fork |
fix: formatting issue
|
@olblak should be ok, I just merged/approved it. |
olblak
approved these changes
Apr 2, 2025
|
Looking at the test, there is something weird with the Updatecli that try to find the latest version for the Go module Instead of retriggering the test for this pull request, I am force merging it |
|
I'll trigger a release new Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4569
Add support for initContainers in k8s manifest files.
Test
Tested with
No warning/error related to autodiscovery/kubernetes.
Manual test
Worked as expected all images got updated.
Additional Information
Checklist
=> Not applicable (?)
Tradeoff
$.spec.template.spec.initContainers[%d].image- The automated test is an incomplete deployment manifest.Potential improvement
More tests to cover all path (see tradeoff above):
$.spec.initContainers[%d].image$.spec.jobTemplate.spec.template.spec.initContainers[%d].imageMore complex test to validate the base behaviour hasn't been skipped by adding a container section.
=> Hasn't been done, couldn't figure out the test validation input to provide in
main_test.go.