ci: update to golangci v2 configuration && fix reported linting issues #4568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticheck reported a lot of issues like * ST1005: error strings should not end with punctuation or newlines * QF1003: could use tagged switch on gr.spec.Key1 * ST1005: error strings should not be capitalized * QF1001: could apply De Morgan's law * SA5001: should check error returned from os.Create() before deferring newFile.Close() * SA4014: this condition occurs multiple times in this if/else if chain * SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead * QF1007: could merge conditional assignment into variable declaration * SA6005: should use strings.EqualFold instead * SA9003: empty branch * QF1008: could remove embedded field "InlineKeyChain" from selector * SA1001: template: :6: unexpected "}" in end * QF1004: could use strings.ReplaceAll instead
1 task
|
I am merging this pr hoping that I am not introducing regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint update to v2 is currently broken.
While the core of Updatecli shouldn't be modified, it's hard to guarantee that I didn't introduce a mistake in the process
golangci-lint started reporting issues in a many packages such as:
Test
To test this pull request, you can run the following commands:
make testAdditional Information
Checklist
Tradeoff
Potential improvement