-
-
Notifications
You must be signed in to change notification settings - Fork 30
chore: release package(s) #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
Deploy preview for prettier ready! ✅ Preview Built with commit 1ffa26d. |
prettier-plugin-autocorrect
prettier-plugin-pkg
prettier-plugin-sh
prettier-plugin-sql
prettier-plugin-toml
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 10 10
Lines 192 192
Branches 49 49
=======================================
Hits 155 155
Misses 36 36
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hold on for #429 |
bb69f07
to
1ffa26d
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/sh/CHANGELOG.md (1)
9-9
: Link Formatting Improvement SuggestionThe standalone note "Please view mvdan/sh#1145 for more details." is informative. For consistency and improved clarity, consider merging this note into the bullet item above so that related details remain bundled together. For example, you might append the note in parentheses at the end of the bullet.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/spotty-beds-applaud.md
(0 hunks)packages/sh/CHANGELOG.md
(1 hunks)packages/sh/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/spotty-beds-applaud.md
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/sh/package.json
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Lint and Test with Node.js 22 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 on windows-latest
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
packages/sh/CHANGELOG.md (2)
3-7
: New Version Section (0.17.0) Added CorrectlyThe new version header and the "Minor Changes" section for 0.17.0 are clear and follow the existing changelog structure. The entry for PR #430 is detailed—with commit reference and contributor acknowledgment—accurately reflecting the change to use
sh-syntax
without the experimental flag and indicating the removal ofmvdan-sh
support.
11-11
: Additional Minor Change Entry for PR #432The entry for PR #432 is well-formatted and clearly explains the prototype feature for using
dockerfmt
as a fallback printer. The description is precise and user-friendly, consistent with the project's changelog style.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
prettier-plugin-sh@0.17.0
Minor Changes
#430
f7e38ae
Thanks @JounQin! - feat(sh): usesh-syntax
without experimental flag, removemvdan-sh
supportPlease view Deprecate
mvdan-sh
npm package in favor ofsh-syntax
mvdan/sh#1145 for more details.#432
d49d6e5
Thanks @JounQin! - feat: prototype to usedockerfmt
as fallbackprinter
, you can also useparser: dockerfile
to enable it specificallySummary by CodeRabbit