packages/sh/test/shellscript.spec.ts (1)

14-21: Same snapshot issue applies here

The snapshot test for the experimental Wasm case is also failing for the same reason. The snapshots need to be updated for both test cases.

packages/sh/README.md (2)

15-15: Use clearer phrasing.

The phrase "with powered by" is awkward. Suggest rewriting for clarity.

-This plugin is still under development, its printer just wraps [mvdan-sh][]'s default printer with powered by [sh-syntax][].
+This plugin is still under development; its printer just wraps [mvdan-sh][]'s default printer, which is powered by [sh-syntax][].

---

18-20: Use “cannot” for more natural phrasing.

-We can not do much on our side.
+We cannot do much on our side.

🧰 Tools

🪛 LanguageTool

[style] ~20-~20: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...sage cases can be handled correctly. We can not do much on our side. ## Requirements ...

(CAN_NOT_PREMIUM)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

.changeset/spotty-beds-applaud.md (1)

5-5: Optional Grammar Improvement

Consider adding the definite article for clarity. If acceptable by the project's style, you might update the message to:
feat(sh): use \sh-syntax` without the experimental flag, remove `mvdan-sh` support`
This makes the phrase read more naturally.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~5-~5: You might be missing the article “the” here.
Context: ... --- feat(sh): use sh-syntax without experimental flag, remove mvdan-sh support Please...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/sh/test/fixtures.spec.ts (1)

26-26: ⚠️ Potential issue

Fix failing snapshot tests.

The simplified error handling approach is good, but it's causing snapshot test failures as shown in the static analysis. The error message format has changed with the new sh-syntax implementation.

You need to update the snapshots to match the new error format:

# Update the failing snapshot tests
yarn test -u

🧰 Tools

🪛 GitHub Check: Lint and Test with Node.js 22 on ubuntu-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 22 on windows-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 20 on windows-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 18 on macos-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 22 on macos-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 20 on ubuntu-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 18 on ubuntu-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 20 on macos-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Check: Lint and Test with Node.js 18 on windows-latest

[failure] 26-26: packages/sh/test/fixtures.spec.ts > parser and printer > should format all fixtures
Error: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

• Expected

• Received

  "; can only immediately follow a statement

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

• 6 | disallow_untyped_defs = True
• 7 | disallow_any_generics = True

• 8 | ; disallow_any_unimported = True

•  | ^
  

• 9 | ; warn_redundant_casts = True
• 10 | ; warn_return_any = True
• 11 | ; warn_unused_configs = True"

❯ packages/sh/test/fixtures.spec.ts:26:40

🪛 GitHub Actions: CI

[error] 26-26: Snapshot parser and printer > should format all fixtures > 146.ini 1 mismatched

.size-limit.json (1)

1-18: JSON Size Limit Configuration is Well Structured

The new .size-limit.json file defines clear size limits for several package entry points. The JSON structure is valid and each entry correctly specifies the "path" and "limit" properties. As the project moves to centralized size limit management, please ensure that any future modifications in package paths or limits remain consistent with this configuration.

package.json (2)

16-16: Updated Build Script with -e named Flag

The "build:r" script has been updated to include the -e named flag ("r -f cjs -e named"). This change aligns with the PR objective to use sh-syntax without relying on experimental flags. Please verify that this flag does not cause any unexpected side effects in your build process.

---

1-115: General Package Configuration Consistency

The changes in package.json—including the removal of @types/mvdan-sh and updates to build scripts and linting dependencies—are consistent with the PR objective of removing mvdan-sh support. Double-check that any remnants of the old mvdan-sh tooling (in documentation, configuration files, or scripts) are also fully removed.

packages/sh/test/error.spec.ts (1)

1-15: ⚠️ Potential issue

Fix failing snapshot tests.

The test is correctly set up to verify error handling for invalid shell syntax, but the snapshot test is failing because the error message format has changed with the switch from mvdan-sh to sh-syntax as indicated in your PR title.

You need to update the snapshot to match the new error format by running:

yarn test -u

This will update all snapshots to match the current output format from the sh-syntax parser.

🧰 Tools

🪛 GitHub Check: Lint and Test with Node.js 22 on ubuntu-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 22 on windows-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 20 on windows-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 18 on macos-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 22 on macos-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 20 on ubuntu-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 18 on ubuntu-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 20 on macos-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Check: Lint and Test with Node.js 18 on windows-latest

[failure] 14-14: packages/sh/test/error.spec.ts > fatal parse error with meaningful message
Error: Snapshot fatal parse error with meaningful message 1 mismatched

• Expected

• Received

  [SyntaxError: a command can only contain words and redirects; encountered )

• 1 | echo )

• |      ^]
  

• 1 | echo )

• |      ^]
  

❯ packages/sh/test/error.spec.ts:14:3

🪛 GitHub Actions: CI

[error] 14-14: Snapshot fatal parse error with meaningful message 1 mismatched

.github/workflows/autofix.yml (1)

28-28: Updated Dependency Install Command: Verify Installation Strategy.
The command has been changed from yarn --immutable to yarn --no-immutable, which allows installation even when the lockfile is out of sync with the package.json. Please confirm that this relaxed approach is acceptable for your project's reliability and that any potential side‐effects (e.g. unexpected dependency resolutions) are understood.

package.json (1)

44-53: ESLint Plugin Updates: Confirm Integration.
The new devDependencies—@stylistic/eslint-plugin-js (v^4.2.0) and eslint-plugin-tsdoc (v^0.4.0)—are now included in your configuration. Please ensure these are correctly configured in your ESLint setup and that they integrate seamlessly with your current linting rules.

packages/sh/README.md (4)

18-22: Refine Warning Message Language.
The warning message regarding Dockerfile and ignore file support could be improved for clarity and correctness. For example, changing “We can not do much on our side” to “We cannot do much on our side” will read more naturally. Also, adding proper punctuation after the URL could enhance readability.

🧰 Tools

🪛 LanguageTool

[style] ~20-~20: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...sage cases can be handled correctly. We can not do much on our side. > See also <https:...

(CAN_NOT_PREMIUM)

---

195-195: Deprecated Property Reminder: keepPadding.
The keepPadding property is marked as deprecated. Ensure that the documentation advises users about its planned removal in the next major version and confirm that any internal references have been updated accordingly.

---

103-103: Markdown Formatting: Replace Hard Tabs with Spaces.
A static analysis check indicates hard tabs on this line. Please replace hard tabs with spaces to comply with markdownlint's MD010 rule.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

103-103: Hard tabs
Column: 6

(MD010, no-hard-tabs)

---

149-149: Markdown Formatting: Remove Hard Tabs.
Please ensure that any hard tabs detected on this line are replaced with spaces, aligning with markdownlint's formatting guidelines.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

149-149: Hard tabs
Column: 6

(MD010, no-hard-tabs)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/sh/README.md (1)

62-154: 🛠️ Refactor suggestion

⚠️ Potential issue

Resolve Duplicate Definitions in ShOptions Interface

Lines 64–108 now introduce optional declarations for properties (keepComments, variant, stopAt, and recoverErrors), but later in the same interface (lines 114–154) these properties are re-declared as required. The duplicate definitions may lead to type conflicts and ambiguity. Please consolidate the interface so that each property is defined only once with the intended (optional) signature. For example, if the new optional declarations are the desired update, remove the duplicate required definitions as shown below:

-  /**
-   * KeepComments makes the parser parse comments and attach them to
-   * nodes, as opposed to discarding them.
-   * @default true
-   */
-  keepComments: boolean
-  /**
-   * LangVariant describes a shell language variant to use when tokenizing and
-   * parsing shell code. The zero value is [LangBash].
-   */
-  variant: LangVariant
-  /**
-   * StopAt configures the lexer to stop at an arbitrary word, treating it
-   * as if it were the end of the input...
-   */
-  stopAt: string
-  /**
-   * RecoverErrors allows the parser to skip up to a maximum number of errors...
-   */
-  recoverErrors: number

Please verify that the merged interface reflects the intended optionality.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

102-102: Hard tabs
Column: 6

(MD010, no-hard-tabs)

---

148-148: Hard tabs
Column: 6

(MD010, no-hard-tabs)

packages/sh/README.md (2)

194-213: New Properties Added: minify, singleLine, and functionNextLine

The additions of minify, singleLine, and functionNextLine provide enhanced customization for the formatter. Their descriptions are clear and well-documented. Please confirm that any underlying implementation (and corresponding tests) has been updated to support these new options.

---

246-247: Verify sh-syntax Link Reference

The link for [sh-syntax] at line 246 now points to https://github.com/un-ts/sh-syntax. Please verify that this URL is correct and that any related documentation reflects its current role after the removal of the experimental flag and mvdan-sh support.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro