Add a make install target
#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogly
approved these changes
Jan 12, 2018
ajfriend
added a commit
to ajfriend/h3
that referenced
this pull request
Sep 8, 2020
ajfriend
added a commit
to ajfriend/h3
that referenced
this pull request
Sep 21, 2020
ajfriend
added a commit
that referenced
this pull request
Sep 27, 2020
* translating over my python/cython code * just testing * revert * try exporting the cell area function * adding a simple test * a few extra functions * exposing great-circle/haversine distance function to user * messing around with everything computing distances! * haversine is a bit better! * numerical tests * function with true haversine formula * remove old note * move to pass by reference * translation bug in _pointDist_mystery * remove _geoDistRads and _geoDistKm in favor of new user-facing functions * spelling * adding todo's just so i can highlight the function * more todo! * refactor the area computation a bit * drop the todos * adding unidirectional edge length functions * add .ipynb_checkpoints to .gitignore * remove alternate distance functions * remove constrainLat and constrainLng * Revert "remove constrainLat and constrainLng" This reverts commit 0962949. * rads -> meters -> kilometers * tests workin! * formatting thing? * tests for the edge length function * bug? * valgrind bugfix * valgring bugfix attempt #2 * valgrind bugfix #3 * much cleaner tests * remove old tests * bug * edge iterator function to clean up tests * edge length tests at several resolutions * refactoring the Earth area test * tests for each group of units * a broken test at resolution 1 * positivity tests * area bug coming from not handling the zero elements in uncompact * area tests up to res 4 * tests for pointDistM * tests for pointDist* functions * documenting packNonzeros * move testing code to src/apps/testapps/testH3CellAreaExhaustive.c * meh * headers not needed * add some test documentation * more function/algorithm notes * more function notes * getCellsAtRes func documentation * fix docs in h3api.h.in * dummy push because valgrind failed last time * update changelog * notes on `make test-fast` * try sudo apt update to fix issue with valgrind * use floats for division * addressing some formatting comments * ordering of measurements in terms of units * clean up some long lines * typo * translating over my python/cython code * just testing * revert * try exporting the cell area function * adding a simple test * a few extra functions * exposing great-circle/haversine distance function to user * messing around with everything computing distances! * haversine is a bit better! * numerical tests * function with true haversine formula * remove old note * move to pass by reference * translation bug in _pointDist_mystery * remove _geoDistRads and _geoDistKm in favor of new user-facing functions * spelling * adding todo's just so i can highlight the function * more todo! * refactor the area computation a bit * drop the todos * adding unidirectional edge length functions * add .ipynb_checkpoints to .gitignore * remove alternate distance functions * remove constrainLat and constrainLng * Revert "remove constrainLat and constrainLng" This reverts commit 0962949. * rads -> meters -> kilometers * tests workin! * formatting thing? * tests for the edge length function * bug? * valgrind bugfix * valgring bugfix attempt #2 * valgrind bugfix #3 * much cleaner tests * remove old tests * bug * edge iterator function to clean up tests * edge length tests at several resolutions * refactoring the Earth area test * tests for each group of units * a broken test at resolution 1 * positivity tests * area bug coming from not handling the zero elements in uncompact * area tests up to res 4 * tests for pointDistM * tests for pointDist* functions * documenting packNonzeros * move testing code to src/apps/testapps/testH3CellAreaExhaustive.c * meh * headers not needed * add some test documentation * more function/algorithm notes * more function notes * getCellsAtRes func documentation * fix docs in h3api.h.in * dummy push because valgrind failed last time * update changelog * notes on `make test-fast` * use floats for division * addressing some formatting comments * ordering of measurements in terms of units * clean up some long lines * typo * updating copyright to 2020 in a few files * few more files * and just a few more * testing area calculations on a few specific cells * formatting * working tests! * add cellArea defgroup * relax error tolerance for Windows... :/
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
Add a `make install` target
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
* translating over my python/cython code * just testing * revert * try exporting the cell area function * adding a simple test * a few extra functions * exposing great-circle/haversine distance function to user * messing around with everything computing distances! * haversine is a bit better! * numerical tests * function with true haversine formula * remove old note * move to pass by reference * translation bug in _pointDist_mystery * remove _geoDistRads and _geoDistKm in favor of new user-facing functions * spelling * adding todo's just so i can highlight the function * more todo! * refactor the area computation a bit * drop the todos * adding unidirectional edge length functions * add .ipynb_checkpoints to .gitignore * remove alternate distance functions * remove constrainLat and constrainLng * Revert "remove constrainLat and constrainLng" This reverts commit 0962949. * rads -> meters -> kilometers * tests workin! * formatting thing? * tests for the edge length function * bug? * valgrind bugfix * valgring bugfix attempt uber#2 * valgrind bugfix uber#3 * much cleaner tests * remove old tests * bug * edge iterator function to clean up tests * edge length tests at several resolutions * refactoring the Earth area test * tests for each group of units * a broken test at resolution 1 * positivity tests * area bug coming from not handling the zero elements in uncompact * area tests up to res 4 * tests for pointDistM * tests for pointDist* functions * documenting packNonzeros * move testing code to src/apps/testapps/testH3CellAreaExhaustive.c * meh * headers not needed * add some test documentation * more function/algorithm notes * more function notes * getCellsAtRes func documentation * fix docs in h3api.h.in * dummy push because valgrind failed last time * update changelog * notes on `make test-fast` * try sudo apt update to fix issue with valgrind * use floats for division * addressing some formatting comments * ordering of measurements in terms of units * clean up some long lines * typo * translating over my python/cython code * just testing * revert * try exporting the cell area function * adding a simple test * a few extra functions * exposing great-circle/haversine distance function to user * messing around with everything computing distances! * haversine is a bit better! * numerical tests * function with true haversine formula * remove old note * move to pass by reference * translation bug in _pointDist_mystery * remove _geoDistRads and _geoDistKm in favor of new user-facing functions * spelling * adding todo's just so i can highlight the function * more todo! * refactor the area computation a bit * drop the todos * adding unidirectional edge length functions * add .ipynb_checkpoints to .gitignore * remove alternate distance functions * remove constrainLat and constrainLng * Revert "remove constrainLat and constrainLng" This reverts commit 0962949. * rads -> meters -> kilometers * tests workin! * formatting thing? * tests for the edge length function * bug? * valgrind bugfix * valgring bugfix attempt uber#2 * valgrind bugfix uber#3 * much cleaner tests * remove old tests * bug * edge iterator function to clean up tests * edge length tests at several resolutions * refactoring the Earth area test * tests for each group of units * a broken test at resolution 1 * positivity tests * area bug coming from not handling the zero elements in uncompact * area tests up to res 4 * tests for pointDistM * tests for pointDist* functions * documenting packNonzeros * move testing code to src/apps/testapps/testH3CellAreaExhaustive.c * meh * headers not needed * add some test documentation * more function/algorithm notes * more function notes * getCellsAtRes func documentation * fix docs in h3api.h.in * dummy push because valgrind failed last time * update changelog * notes on `make test-fast` * use floats for division * addressing some formatting comments * ordering of measurements in terms of units * clean up some long lines * typo * updating copyright to 2020 in a few files * few more files * and just a few more * testing area calculations on a few specific cells * formatting * working tests! * add cellArea defgroup * relax error tolerance for Windows... :/
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easy to install H3 system-wide. Assuming the library was installed system-wide, the commands for building the example become much simpler.