Disable TLS1.0 #355
Merged
Disable TLS1.0 #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelynl94
approved these changes
Apr 25, 2024
shilazi
added a commit
to shilazi/kraken
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS 1.0 is considered vulnerability and requested to be disabled.
It should be a noop change since in the client side, we don't set minVersion and MaxVersion field in the TLS config so the default minVersion is 1.2 and the default maxVersion is 1.3.
For example, Kraken internal clients TLS config: https://sourcegraph.com/github.com/uber/kraken@master/-/blob/utils/httputil/tls.go?L91
uBuild TLS config: https://sg.uberinternal.com/code.uber.internal/uber-code/go-code/-/blob/src/code.uber.internal/infra/ubuild/build/gateway/kraken/http_client.go?L63