Shutdown: Don't stop receiver, deprecate ShutdownTimeout #1082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of:
However, since I can't push branches directly to this repository,
this PR shows commits from both PRs.
Shutdowner.Shutdown is not a blocking operation.
It does not need to block and wait for the relay goroutine to stop;
signalReceiver.Stop will do that.
To clarify this further, signalReceivers has the following operations:
chan ShutdownSignal
chan os.Signal
The only reason that the relay goroutine exists is
to map
os.Signal
s received byos/signal.Notify
into an
fx.ShutdownSignal
.Shutdowner.Shutdown should not call signalReceivers.Stop
because the relay goroutine should keep running
so that we can re-use Shutdowner.Shutdown.
This change exposed a leak in TestDataRace (fixed in #1081).