Skip to content

feat: refactor more core utils to make them importable #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 7, 2025
Merged

feat: refactor more core utils to make them importable #3423

merged 6 commits into from
Aug 7, 2025

Conversation

andreynering
Copy link
Contributor

@andreynering andreynering commented Jul 22, 2025 •
edited
Loading

@andreynering andreynering self-assigned this Jul 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 70.58824% with 145 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.30%. Comparing base (7b50ad4) to head (b11de6c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
- Coverage   59.34%   59.30%   -0.04%     
==========================================
  Files         630      636       +6     
  Lines       53739    53932     +193     
==========================================
+ Hits        31889    31982      +93     
- Misses      21850    21950     +100
Flag Coverage Δ
.-amd64 88.88% <ø> (ø)
cmds/...-amd64 49.15% <0.00%> (-0.21%) ⬇️
integration/generic-tests/...-amd64 30.51% <ø> (ø)
integration/generic-tests/...-arm 32.15% <ø> (ø)
integration/generic-tests/...-arm64 29.80% <ø> (ø)
integration/gotests/...-amd64 59.76% <71.75%> (-0.09%) ⬇️
integration/gotests/...-arm 60.38% <71.75%> (+0.14%) ⬆️
integration/gotests/...-arm64 60.63% <71.75%> (+0.24%) ⬆️
pkg/...-amd64 57.45% <72.95%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 64.19% <70.58%> (-0.07%) ⬇️
cmds/exp 31.19% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreynering andreynering force-pushed the more-coreutils branch 4 times, most recently from 05ca75d to ffafe9a Compare July 28, 2025 13:07
@AjanZhong
Copy link
Contributor

@andreynering Hi Andrey, we noticed that your PR failed at ARM integration test. Now we have fixed this ARM integration test issue, would you mind help rebase your PR, then Github CI will trigger integration test again. Thanks.

@andreynering andreynering force-pushed the more-coreutils branch 2 times, most recently from eaf7ea7 to bb6a223 Compare August 7, 2025 18:57
@andreynering andreynering marked this pull request as ready for review August 7, 2025 18:57
@andreynering
Copy link
Contributor Author

I implemented the missing core utils from my list (base64). The PR is ready to review.

I couple of fixes were made to base64 in the process, by the way:

  • It wasn't outputing with a ending line break like GNU does. Doing that now for compatibility.
  • Changed from base64.RawStdEncoding to base64.StdEncoding, also for compatilibity reasons.

@andreynering andreynering requested a review from rminnich August 7, 2025 19:01
rminnich
rminnich approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to come together.
Fingers crossed, there's a lot here, but it looks fine.

@andreynering andreynering enabled auto-merge (rebase) August 7, 2025 19:54
@andreynering
feat(mktemp): refactor mktemp core util to use the new api design
94c33b4 
Signed-off-by: Andrey Nering <andreynering@users.noreply.github.com>
@andreynering
feat(tar): refactor tar core util to use the new api design
bc7fded 
Signed-off-by: Andrey Nering <andreynering@users.noreply.github.com>
@andreynering
feat(gzip): refactor gzip core util to use the new api design
d23df7b 
Signed-off-by: Andrey Nering <andreynering@users.noreply.github.com>
@andreynering
feat(shasum): refactor shasum core util to use the new api design
be1d6fd 
Signed-off-by: Andrey Nering <andreynering@users.noreply.github.com>
@andreynering
refactor(shasum): remove unused parameter
0beae58 
Signed-off-by: Andrey Nering <andreynering@users.noreply.github.com>
@andreynering
feat(base64): refactor base64 core util to use the new api design
b11de6c 
Signed-off-by: Andrey Nering <andreynering@users.noreply.github.com>
@andreynering andreynering merged commit 5e77210 into main Aug 7, 2025
31 checks passed
@andreynering andreynering deleted the more-coreutils branch August 7, 2025 20:06
andreynering added a commit to mvdan/sh that referenced this pull request Aug 7, 2025
@andreynering
chore(deps): update u-root to include 5 more core utils
b27295b 
* base64
* gzip
* mktemp
* shasum
* tar

u-root/u-root#3423
andreynering added a commit to mvdan/sh that referenced this pull request Aug 7, 2025
@andreynering
moreinterp/coreutils: update u-root to include 5 more core utils
5ec4bea 
* base64
* gzip
* mktemp
* shasum
* tar

u-root/u-root#3423
@andreynering andreynering mentioned this pull request Aug 7, 2025
Merged
andreynering added a commit to mvdan/sh that referenced this pull request Aug 7, 2025
@andreynering
moreinterp/coreutils: update u-root to include 5 more core utils
e42adb0 
* base64
* gzip
* mktemp
* shasum
* tar

u-root/u-root#3423
@andreynering andreynering mentioned this pull request Aug 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rminnich rminnich rminnich approved these changes

Assignees

@andreynering andreynering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreynering @AjanZhong @rminnich