Move server to runner. Launch it only once. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thanks so much @paulirish! :) |
trueadm
pushed a commit
that referenced
this pull request
Aug 29, 2019
Fix encoding of Unicode keys greater than U+00FF
trueadm
added a commit
that referenced
this pull request
Dec 18, 2019
trueadm
added a commit
that referenced
this pull request
Dec 18, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2
trueadm
added a commit
that referenced
this pull request
Dec 18, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug
trueadm
added a commit
that referenced
this pull request
Dec 18, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup
trueadm
added a commit
that referenced
this pull request
Dec 19, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback
trueadm
added a commit
that referenced
this pull request
Dec 19, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback Fix flow
trueadm
added a commit
that referenced
this pull request
Dec 20, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback Fix flow Major refactor and re-design
trueadm
added a commit
that referenced
this pull request
Dec 20, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback Fix flow Major refactor and re-design More revisions
trueadm
added a commit
that referenced
this pull request
Dec 20, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback Fix flow Major refactor and re-design More revisions Cleanup
trueadm
added a commit
that referenced
this pull request
Dec 20, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback Fix flow Major refactor and re-design More revisions Cleanup Cleanup 2
trueadm
added a commit
that referenced
this pull request
Dec 20, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback Fix flow Major refactor and re-design More revisions Cleanup Cleanup 2 Add DCE and unmounting logic for host instances
trueadm
added a commit
that referenced
this pull request
Dec 20, 2019
Update error codes fix lint DCE fix test Add event kinds to help propagation rules Add event kinds to help propagation rules #2 Fix kind bug cleanup Address feedback Fix flow Major refactor and re-design More revisions Cleanup Cleanup 2 Add DCE and unmounting logic for host instances Fix merge conflicts
trueadm
added a commit
that referenced
this pull request
Mar 10, 2020
trueadm
added a commit
that referenced
this pull request
Mar 10, 2020
Add test Fix Address feedback fix Fix flow types Fix Fix Wtf? Fix path Fix Fix bundles... Fix CI tests, by adding to experimental build Attempt #2 at fixing CI Revert
trueadm
added a commit
that referenced
this pull request
Mar 10, 2020
Add test Fix Address feedback fix Fix flow types Fix Fix Wtf? Fix path Fix Fix bundles... Fix CI tests, by adding to experimental build Attempt #2 at fixing CI Revert Fix
trueadm
added a commit
that referenced
this pull request
Mar 10, 2020
Add test Fix Address feedback fix Fix flow types Fix Fix Wtf? Fix path Fix Fix bundles... Fix CI tests, by adding to experimental build Attempt #2 at fixing CI Revert Fix Fix lint
trueadm
added a commit
that referenced
this pull request
Mar 12, 2020
Address feedback Address feedback Address feedback #2 Adjust changes
trueadm
added a commit
that referenced
this pull request
Mar 12, 2020
Address feedback Address feedback Address feedback #2 Adjust changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the ultimate bug is that
server.close()wasn't closing the server.. so a subsequent request for localhost:8080 was continuing to provide the original files, since the filerootfor the server was set back then.This is the fix that made sense for me... but there's a few ways to do this. No worries if you'd rather solve it differently :)
no-storerather thanno-cachebut really this shouldn't matter. This part is @patrickhulce's fault. ;)This closes GoogleChrome/lighthouse#2064