Skip to content

Conversation

davidpdrsn
Copy link
Member

A small convenience for doing .service(service_fn(handler_function)).

A small convenience for doing `.service(service_fn(handler_function))`.
@davidpdrsn davidpdrsn added the A-builder Area: Tower's service builder label Feb 21, 2021
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on some potential docs improvements, but other than that, this looks great!

@davidpdrsn davidpdrsn merged commit 7461abc into master Feb 25, 2021
@davidpdrsn davidpdrsn deleted the david/builder-service-fn branch February 25, 2021 21:52
hawkw added a commit that referenced this pull request Feb 27, 2021
Deprecated

- **util**: Deprecated `ServiceExt::ready_and` (renamed to
  `ServiceExt::ready`). ([#567])
- **util**: Deprecated `ReadyAnd` future (renamed to `Ready`). ([#567])

Added

- **builder**: Add `ServiceBuilder::layer_fn` to add a layer built from
  a function. ([#560])
- **builder**: Add `ServiceBuilder::map_future` for transforming the
  futures produced by a service. ([#559])
- **builder**: Add `ServiceBuilder::service_fn` for applying `Layer`s to
  an async function using `util::service_fn`. ([#564])
- **util**: Add example for `service_fn`. ([#563])
- **util**: Add `BoxLayer` for creating boxed `Layer` trait objects.
  ([#569])

[#567]: #567
[#560]: #560
[#559]: #559
[#564]: #564
[#563]: #563
[#569]: #569
davidpdrsn pushed a commit that referenced this pull request Feb 27, 2021
Deprecated

- **util**: Deprecated `ServiceExt::ready_and` (renamed to
  `ServiceExt::ready`). ([#567])
- **util**: Deprecated `ReadyAnd` future (renamed to `Ready`). ([#567])

Added

- **builder**: Add `ServiceBuilder::layer_fn` to add a layer built from
  a function. ([#560])
- **builder**: Add `ServiceBuilder::map_future` for transforming the
  futures produced by a service. ([#559])
- **builder**: Add `ServiceBuilder::service_fn` for applying `Layer`s to
  an async function using `util::service_fn`. ([#564])
- **util**: Add example for `service_fn`. ([#563])
- **util**: Add `BoxLayer` for creating boxed `Layer` trait objects.
  ([#569])

[#567]: #567
[#560]: #560
[#559]: #559
[#564]: #564
[#563]: #563
[#569]: #569
hawkw added a commit that referenced this pull request Mar 1, 2021
Deprecated

- **util**: Deprecated `ServiceExt::ready_and` (renamed to
  `ServiceExt::ready`). ([#567])
- **util**: Deprecated `ReadyAnd` future (renamed to `Ready`). ([#567])

Added

- **builder**: Add `ServiceBuilder::layer_fn` to add a layer built from
  a function. ([#560])
- **builder**: Add `ServiceBuilder::map_future` for transforming the
  futures produced by a service. ([#559])
- **builder**: Add `ServiceBuilder::service_fn` for applying `Layer`s to
  an async function using `util::service_fn`. ([#564])
- **util**: Add example for `service_fn`. ([#563])
- **util**: Add `BoxLayer` for creating boxed `Layer` trait objects.
  ([#569])

[#567]: #567
[#560]: #560
[#559]: #559
[#564]: #564
[#563]: #563
[#569]: #569

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builder Area: Tower's service builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants