Skip to content

feat: support update PlatformIO Core #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2024
Merged

feat: support update PlatformIO Core #759

merged 1 commit into from
Apr 7, 2024

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
    Should work
  • Optional: The --dry-run option works with this step
    Should work as there is only 1 command to execute
  • Optional: The --yes option works with this step if it is supported by
    the underlying command
    This does not seem to be supported

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Closes #754

@SteveLauC
Copy link
Member Author

cc @Auravendill, do you want a binary with this patch included to test? I can give you a Linux/Amd64 binary if you would like to.

@codecov Codecov
Copy link

codecov bot commented Mar 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 5.01%. Comparing base (ab21600) to head (8661cc9).

Files Patch % Lines
src/steps/generic.rs 0.00% 12 Missing ⚠️
src/main.rs 0.00% 3 Missing ⚠️
src/config.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #759      +/-   ##
========================================
- Coverage   5.02%   5.01%   -0.01%     
========================================
  Files         37      37              
  Lines      12114   12132      +18     
========================================
  Hits         609     609              
- Misses     11505   11523      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Auravendill
Copy link

cc @Auravendill, do you want a binary with this patch included to test? I can give you a Linux/Amd64 binary if you would like to.

Yeah, that would be great. Most of my machines are Linux/Amd64, so that would work well.

@SteveLauC
Copy link
Member Author

cc @Auravendill, do you want a binary with this patch included to test? I can give you a Linux/Amd64 binary if you would like to.

Yeah, that would be great. Most of my machines are Linux/Amd64, so that would work well.

https://github.com/SteveLauC/topgrade/releases/tag/pr759 Here you go

@Auravendill
Copy link

cc @Auravendill, do you want a binary with this patch included to test? I can give you a Linux/Amd64 binary if you would like to.

Yeah, that would be great. Most of my machines are Linux/Amd64, so that would work well.

https://github.com/SteveLauC/topgrade/releases/tag/pr759 Here you go

I tested it on my machine and it worked exactly as hoped.

@SteveLauC SteveLauC merged commit d90ce30 into topgrade-rs:main Apr 7, 2024
@SteveLauC SteveLauC deleted the feat/platform_io branch April 7, 2024 03:03
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
@SteveLauC @InnocentZero
feat: support update PlatformIO Core (topgrade-rs#759)
dc13f11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support for PlatformIO Core update
2 participants
@SteveLauC @Auravendill