Skip to content

Conversation

niStee
Copy link
Contributor

@niStee niStee commented Feb 25, 2024

  • Refine the testing matrix to include only stable and nightly versions of Rust
  • Add 'fail_ci_if_error' option to Codecov step for stricter CI checks
  • Ensure newline at end of file

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

- Refine the testing matrix to include only stable and nightly versions of Rust
- Add 'fail_ci_if_error' option to Codecov step for stricter CI checks
- Ensure newline at end of file
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@0e30e05). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #718   +/-   ##
======================================
  Coverage        ?   5.65%           
======================================
  Files           ?      37           
  Lines           ?   11503           
  Branches        ?       0           
======================================
  Hits            ?     651           
  Misses          ?   10852           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niStee
Copy link
Contributor Author

niStee commented Feb 25, 2024

While reviewing the logs of the other PR, I noticed that the macOS Codecov report could not be uploaded due to an incorrect secret. It is strange because it uses the same workflow step, isn't it?

@SteveLauC
Copy link
Member

It is strange because it uses the same workflow step, isn't it?

Indeed, they all use the same token, so weird.

@niStee
Copy link
Contributor Author

niStee commented Feb 25, 2024

It is strange because it uses the same workflow step, isn't it?

Indeed, they all use the same token, so weird.

I need to sleep first. Try to debug it later.

@SteveLauC
Copy link
Member

Seems that there are indeed some issues with the token, other checks succeed because:

info - 2024-02-25 03:01:39,390 -- The PR is happening in a forked repo. Using tokenless upload.

@SteveLauC SteveLauC merged commit 9b6027f into topgrade-rs:main Feb 25, 2024
@SteveLauC
Copy link
Member

It is my fault, the token is wrong, I have corrected it.

@niStee niStee deleted the fix/update-codecov-workflow branch February 25, 2024 08:35
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
- Refine the testing matrix to include only stable and nightly versions of Rust
- Add 'fail_ci_if_error' option to Codecov step for stricter CI checks
- Ensure newline at end of file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants