Skip to content

feat(wsl): pass verbose to topgrade-in-wsl #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2023
Merged

feat(wsl): pass verbose to topgrade-in-wsl #556

merged 3 commits into from
Sep 26, 2023

Conversation

ssmendon
Copy link
Contributor

Closes #521

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC

I'd appreciate any feedback about this PR.

@ssmendon ssmendon mentioned this pull request Sep 23, 2023
Closed
SteveLauC
SteveLauC reviewed Sep 25, 2023
View reviewed changes
@SteveLauC
Copy link
Member

Sorry for the late review, except for the comment nitpick, this PR LGTM! Thanks!

BTW, thanks for the comment, it helps code review a lot! :)

@SteveLauC
Copy link
Member

LGTM! Thanks :)

@ssmendon
Copy link
Contributor Author

I did the previous comment fixes in the GitHub UI. Since I noticed it failed the rustfmt check, I pulled it down and did everything for submitting a PR.

@SteveLauC SteveLauC merged commit b3f152b into topgrade-rs:master Sep 26, 2023
@ssmendon ssmendon deleted the 521 branch September 26, 2023 03:17
@p-linnane p-linnane mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-v should be passed to WSL when it is passed on host
2 participants
@ssmendon @SteveLauC