subscriber: update tracing-core to v0.1.33 #3201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change #2954 was released in 0.3.19 (#3162). Notably, it relied on features from tracing-core 0.1.33, however, the version was never bumped. Users of the `tracing` feature of `tracing-subscriber` would have no issue since it pulls in the higher version transitively. The specific feature used was implementing trait method `record_bytes` from the `field::Visit` trait on `JsonVisitor` from the tracing-subscriber json format module. (see linked #2945, or [ `impl field::Visit for JsonVisitor<'_>`](https://github.com/tokio-rs/tracing/blame/master/tracing-subscriber/src/fmt/format/json.rs#L491)) I believe this dependency mismatch requires users to manually select the higher tracing-core version or suffer compilation failure. This probably reflects some failure in how the tests utilize features and intra-workspace dependencies, but, a resolution for that is beyond my current comprehension of the project.
davidbarsky
approved these changes
Jan 27, 2025
Amberley-Sz
pushed a commit
to Amberley-Sz/tracing
that referenced
this pull request
Mar 10, 2025
This reverts commit bfca546.
u-kai
pushed a commit
to u-kai/tracing
that referenced
this pull request
May 11, 2025
The change tokio-rs#2954 was released in 0.3.19 (tokio-rs#3162). Notably, it relied on features from tracing-core 0.1.33, however, the version was never bumped. Users of the `tracing` feature of `tracing-subscriber` would have no issue since it pulls in the higher version transitively. The specific feature used was implementing trait method `record_bytes` from the `field::Visit` trait on `JsonVisitor` from the tracing-subscriber json format module. (see linked tokio-rs#2945, or [ `impl field::Visit for JsonVisitor<'_>`](https://github.com/tokio-rs/tracing/blame/master/tracing-subscriber/src/fmt/format/json.rs#L491)) I believe this dependency mismatch requires users to manually select the higher tracing-core version or suffer compilation failure. This probably reflects some failure in how the tests utilize features and intra-workspace dependencies, but, a resolution for that is beyond my current comprehension of the project. Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #2954 was released in 0.3.19 (#3162).
Notably, it relied on features from tracing-core 0.1.33, however, the
version was never bumped. Users of the
tracingfeature oftracing-subscriberwould have no issue since it pulls in the higherversion transitively.
The specific feature used was implementing trait method
record_bytesfrom the
field::Visittrait onJsonVisitorfrom thetracing-subscriber json format module. (see linked #2945, or
impl field::Visit for JsonVisitor<'_>)I believe this dependency mismatch requires users to manually select the
higher tracing-core version or suffer compilation failure.
This probably reflects some failure in how the tests utilize features
and intra-workspace dependencies, but, a resolution for that is beyond
my current comprehension of the project.
This PR was created based on #3176 by @nkconnor, because it looks like
our job rules don't allow non-members to run jobs on PRs against the
v0.1.xbranch (there's no button for me to approve the run).