Skip to content

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Dec 19, 2024

Closes #3079.
cc @Turbo87

@jplatte jplatte requested a review from yanns December 19, 2024 20:09
@jplatte jplatte force-pushed the jplatte/opt-query-removal branch 2 times, most recently from 3ec8de3 to 9eb731f Compare December 19, 2024 21:54
@jplatte jplatte force-pushed the jplatte/opt-query-removal branch from 9eb731f to 2f1fd5b Compare December 21, 2024 19:11
@jplatte jplatte merged commit 3bb12ab into main Dec 25, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/opt-query-removal branch December 25, 2024 17:56
xmo-odoo added a commit to xmo-odoo/dummy_central that referenced this pull request Feb 21, 2025
Pretty much all the changes are from updating axum to 0.8:

- `async_trait` has been dropped because Return Position `impl Trait`
  (RPIT) makes it unnecessary
- routing placeholders changed from `:foo`/`*foo` to `{foo}`/`{*foo}`
- `Option<extractor>` requires implementing `OptionalFromRequestPart`
- `Option<Query<T>>` doesn't work anymore (tokio-rs/axum#3088) but
  apparently the behaviour was always kinda dodgy
  (tokio-rs/axum#3079)? It's only used for the `/info/refs` service
  query parameter, in which case I can move the `Option` inside the
  struct which cleans up the body (and allows avoiding an allocation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axum 0.8.0-rc.1: optional query parameters
3 participants