Skip to content

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Oct 14, 2024

Operating System
Ubuntu
24.04.1
LTS

Github ubuntu-latest now points to 24.04.1
actions/runner-images#10636 (comment)

related possible fix electron/electron#17972 (comment)

Copy link
Contributor

graphite-app bot commented Oct 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Oct 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the test Related to test cases label Oct 14, 2024
Copy link

nx-cloud bot commented Oct 14, 2024

@pengx17 pengx17 marked this pull request as ready for review October 14, 2024 09:18
@graphite-app graphite-app bot requested a review from forehalo October 14, 2024 09:18
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (79ef8c3) to head (96d3692).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8492   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files         528      528           
  Lines       33259    33259           
  Branches     2931     2931           
=======================================
  Hits        23324    23324           
  Misses       9587     9587           
  Partials      348      348           
Flag Coverage Δ
server-test 76.82% <ø> (ø)
unittest 45.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 10-14-chore_enable_pw_logging_for_electron_tests branch from 17ac33e to 48aa010 Compare October 14, 2024 09:30
@pengx17 pengx17 changed the title chore: enable pw logging for electron tests chore: electron tests on ubuntu 24 Oct 14, 2024
@pengx17 pengx17 changed the title chore: electron tests on ubuntu 24 test(electron): electron tests on ubuntu 24 Oct 14, 2024
@pengx17 pengx17 force-pushed the 10-14-chore_enable_pw_logging_for_electron_tests branch from 48aa010 to 0a7d168 Compare October 14, 2024 09:40
Copy link
Contributor

graphite-app bot commented Oct 14, 2024

Merge activity

  • Oct 14, 5:55 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 14, 6:09 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Mobile Test (1)').
  • Oct 14, 6:19 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 14, 6:33 AM EDT: A user merged this pull request with the Graphite merge queue.

pengx17 added a commit that referenced this pull request Oct 14, 2024
Operating System
  Ubuntu
  24.04.1
  LTS

Github ubuntu-latest has points to 24.04.1
actions/runner-images#10636 (comment)

related possible fix electron/electron#17972 (comment)
@pengx17 pengx17 force-pushed the 10-14-chore_enable_pw_logging_for_electron_tests branch from 0a7d168 to 42ff852 Compare October 14, 2024 09:56
Operating System
  Ubuntu
  24.04.1
  LTS

Github ubuntu-latest now points to 24.04.1
actions/runner-images#10636 (comment)

related possible fix electron/electron#17972 (comment)
@EYHN EYHN force-pushed the 10-14-chore_enable_pw_logging_for_electron_tests branch from 42ff852 to 96d3692 Compare October 14, 2024 10:20
@graphite-app graphite-app bot merged commit 96d3692 into canary Oct 14, 2024
37 checks passed
@graphite-app graphite-app bot deleted the 10-14-chore_enable_pw_logging_for_electron_tests branch October 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SUID sandbox helper binary was found, but is not configured correctly
3 participants