Fix problem with spaces in directory path #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the current directory had spaces in the directory path, this script would fail. That has been fixed by appropriate use of quotes.
inkarkat
approved these changes
Apr 14, 2019
cunla
approved these changes
Nov 14, 2020
|
For this PR, could someone go through and quote all variables needed? |
wwalker
pushed a commit
to wwalker/todo.txt-cli
that referenced
this pull request
Sep 19, 2021
If the current directory had spaces in the directory path, this script would fail. That has been fixed by appropriate use of quotes. Co-authored-by: Tim Learmont <learmont@NocturnalAviation.com> Co-authored-by: Ali Karbassi <ali@karbassi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current directory had spaces in the directory path, this script would fail.
That has been fixed by appropriate use of quotes.
Before submitting a pull request, please make sure the following is done:
master.Heck, now I can actually run the test suite, whereas before, I couldn't
fixes Spaces in directory cause problems with tests #275