Skip to content

feat: add support for named vectorizers to ai.vectorizer_errors #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 14, 2025
Merged

feat: add support for named vectorizers to ai.vectorizer_errors #683

merged 10 commits into from
May 14, 2025

Conversation

smoya
Copy link
Contributor

@smoya smoya commented Apr 30, 2025 •
edited by Askir
Loading

BEGIN_COMMIT_OVERRIDE
chore: vectorizer_errors change was reverted
END_COMMIT_OVERRIDE

@smoya smoya temporarily deployed to internal-contributors April 30, 2025 17:41 — with GitHub Actions Inactive
@cevian
Copy link
Collaborator

cevian commented May 1, 2025

I don't like having to materialize a name in this table. Maybe a better approach is to move the table to ai._vectorizer_errors and create a view ai.vectorizer_errors that does the join?

@smoya
Copy link
Contributor Author

smoya commented May 2, 2025 •
edited
Loading

I don't like having to materialize a name in this table. Maybe a better approach is to move the table to ai._vectorizer_errors and create a view ai.vectorizer_errors that does the join?

Yeah, that sounds more clever 👍.

EDIT: I made the needed changes. Pending to add a test to this.

@smoya smoya temporarily deployed to internal-contributors May 2, 2025 13:48 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from 641adeb to ec200a3 Compare May 2, 2025 13:48
@smoya smoya temporarily deployed to internal-contributors May 2, 2025 13:49 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from ec200a3 to d6ab192 Compare May 2, 2025 13:49
@smoya smoya temporarily deployed to internal-contributors May 2, 2025 13:50 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from d6ab192 to 02274c7 Compare May 2, 2025 13:56
@smoya smoya temporarily deployed to internal-contributors May 2, 2025 13:56 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from 02274c7 to 8487887 Compare May 6, 2025 09:09
@smoya smoya had a problem deploying to internal-contributors May 6, 2025 09:09 — with GitHub Actions Error
@smoya smoya temporarily deployed to internal-contributors May 6, 2025 09:09 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from d792b59 to 349b1f3 Compare May 6, 2025 09:10
@smoya smoya temporarily deployed to internal-contributors May 6, 2025 09:10 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from 349b1f3 to 0ed8db7 Compare May 6, 2025 09:14
@smoya smoya temporarily deployed to internal-contributors May 6, 2025 09:14 — with GitHub Actions Inactive
@smoya smoya temporarily deployed to internal-contributors May 6, 2025 10:21 — with GitHub Actions Inactive
@smoya smoya temporarily deployed to internal-contributors May 6, 2025 10:27 — with GitHub Actions Inactive
@smoya smoya temporarily deployed to internal-contributors May 6, 2025 11:06 — with GitHub Actions Inactive
smoya
smoya commented May 6, 2025
View reviewed changes
cevian
cevian requested changes May 7, 2025
View reviewed changes
@smoya smoya temporarily deployed to internal-contributors May 8, 2025 09:25 — with GitHub Actions Inactive
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from 40997cb to b8201eb Compare May 8, 2025 09:29
@smoya smoya temporarily deployed to internal-contributors May 8, 2025 09:30 — with GitHub Actions Inactive
@smoya smoya temporarily deployed to internal-contributors May 8, 2025 12:10 — with GitHub Actions Inactive
smoya and others added 6 commits May 9, 2025 11:15
@smoya
feat: grant permission on the incremental sql
5964a84
@smoya
feat: make _vectorizer_errors as default errors_table
fa6180a
@smoya @cevian
feat: update projects/pgai/db/sql/incremental/030-add_vectorizer_erro…
7afac20 
…rs_view.sql

Co-authored-by: Matvey Arye <cevian@gmail.com>
Signed-off-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
@smoya @cevian
feat: update projects/pgai/db/sql/incremental/030-add_vectorizer_erro…
7f00e89 
…rs_view.sql

Co-authored-by: Matvey Arye <cevian@gmail.com>
Signed-off-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
@smoya
feat: rename index instead
5e32c22
@smoya
fix: proper format sql
bd06439
@smoya smoya force-pushed the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch from 3033eae to bd06439 Compare May 9, 2025 09:51
@smoya smoya temporarily deployed to internal-contributors May 9, 2025 09:51 — with GitHub Actions Inactive
@smoya smoya marked this pull request as ready for review May 9, 2025 09:52
@smoya smoya requested a review from a team as a code owner May 9, 2025 09:52
@smoya smoya requested a review from cevian May 9, 2025 10:06
@smoya
Copy link
Contributor Author

smoya commented May 9, 2025

All good to a last round of review 🚀

cevian
cevian approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a foliowup we need upgrade tests

@smoya smoya merged commit 2a77389 into main May 14, 2025
14 checks passed
@smoya smoya deleted the smoya/ai-675-vectorizer_errors-supporting-named-vectorizers branch May 14, 2025 07:55
@github-actions github-actions bot mentioned this pull request May 14, 2025
Merged
smoya added a commit that referenced this pull request May 14, 2025
@smoya
Revert "feat: add support for named vectorizers to ai.vectorizer_erro…
274042a 
…rs (#683)"

This reverts commit 2a77389.
@smoya smoya mentioned this pull request May 14, 2025
Merged
Askir pushed a commit that referenced this pull request May 14, 2025
@smoya
Revert "feat: add support for named vectorizers to ai.vectorizer_erro…
054ff83 
…rs (#683)" (#735)

This reverts commit 2a77389.
This was referenced May 14, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cevian cevian cevian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoya @cevian