Skip to content

scheduler: adjust hot region config when pd-ctl return #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 16, 2021
Merged

scheduler: adjust hot region config when pd-ctl return #3982

merged 9 commits into from
Aug 16, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Aug 12, 2021

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

adjust hot region config when pd-ctl return，ensure that the return result of pd-ctl is consistent with the actual running scheduler

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
adjust config when pd-ctl return
c03ee03 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 added component/scheduler Scheduler logic. needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Aug 12, 2021
@lhy1024 lhy1024 requested review from Yisaer and HunDunDM August 12, 2021 13:22
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 12, 2021
Yisaer
Yisaer reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 13, 2021
@lhy1024
Merge branch 'master' of github.com:tikv/pd into pd-ctl-return
a79d623 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #3982 (6012338) into master (e137de4) will increase coverage by 0.09%.
The diff coverage is 96.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3982      +/-   ##
==========================================
+ Coverage   74.67%   74.76%   +0.09%     
==========================================
  Files         250      250              
  Lines       25511    25541      +30     
==========================================
+ Hits        19051    19097      +46     
+ Misses       4774     4765       -9     
+ Partials     1686     1679       -7
Flag Coverage Δ
unittests 74.76% <96.36%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 83.10% <75.00%> (-0.62%) ⬇️
pkg/mock/mockcluster/mockcluster.go 95.26% <100.00%> (+0.01%) ⬆️
server/schedulers/hot_region_config.go 92.00% <100.00%> (+2.60%) ⬆️
tests/pdctl/helper.go 100.00% <100.00%> (ø)
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/member/member.go 63.10% <0.00%> (-3.75%) ⬇️
server/schedule/operator/step.go 68.10% <0.00%> (-1.00%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
client/base_client.go 82.29% <0.00%> (-0.53%) ⬇️
server/cluster/cluster.go 82.33% <0.00%> (-0.36%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e137de4...6012338. Read the comment docs.

rleungx
rleungx reviewed Aug 13, 2021
View reviewed changes
HunDunDM
HunDunDM reviewed Aug 13, 2021
View reviewed changes
lhy1024 added 3 commits August 13, 2021 21:23
@lhy1024
address comments
e03319f 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
address comments
f3878ec 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
address comments
d5d5764 
Signed-off-by: lhy1024 <admin@liudos.us>
rleungx
rleungx reviewed Aug 16, 2021
View reviewed changes
lhy1024 added 2 commits August 16, 2021 13:17
@lhy1024
address comment
8f97efe 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
address comment
e984d3e 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2021
@lhy1024
address comment
103b357 
Signed-off-by: lhy1024 <admin@liudos.us>
Yisaer
Yisaer reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 16, 2021

/rebuild

@nolouch
Copy link
Contributor

nolouch commented Aug 16, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6012338

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@ti-chi-bot ti-chi-bot merged commit ab0125b into tikv:master Aug 16, 2021
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 16, 2021
@lhy1024 @HunDunDM @ti-chi-bot
scheduler: adjust hot region config when pd-ctl return (tikv#3982)
3562c21 
* adjust config when pd-ctl return

Signed-off-by: lhy1024 <admin@liudos.us>

* address comments

Signed-off-by: lhy1024 <admin@liudos.us>

* address comments

Signed-off-by: lhy1024 <admin@liudos.us>

* address comments

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: 混沌DM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 16, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3992.

ti-chi-bot added a commit that referenced this pull request Aug 16, 2021
@ti-chi-bot @lhy1024 @HunDunDM
scheduler: adjust hot region config when pd-ctl return (#3982) (#3992)
4c176e8 
* adjust config when pd-ctl return

Signed-off-by: lhy1024 <admin@liudos.us>

* address comments

Signed-off-by: lhy1024 <admin@liudos.us>

* address comments

Signed-off-by: lhy1024 <admin@liudos.us>

* address comments

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: 混沌DM <hundundm@gmail.com>

Co-authored-by: lhy1024 <admin@liudos.us>
Co-authored-by: 混沌DM <hundundm@gmail.com>
@lhy1024 lhy1024 mentioned this pull request Aug 20, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
component/scheduler Scheduler logic. needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lhy1024 @ti-chi-bot @nolouch @Yisaer @HunDunDM @rleungx