Skip to content

scheduler: support priority for each dimension in hot scheduling #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 29, 2021
Merged

scheduler: support priority for each dimension in hot scheduling #3920

merged 13 commits into from
Jul 29, 2021

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jul 28, 2021 •
edited
Loading

Signed-off-by: yisaer disxiaofei@163.com

What is changed and how it works?

support priority for each dimension in hot scheduling

Check List

Tests

  • Unit test

I used oltp_read_only to test the dimension priority in hot scheduling, here is the result.

image

Release note

Support priority for each dimension in hot scheduleing

@Yisaer
support priority
ffd59f2 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 28, 2021
@ti-chi-bot ti-chi-bot requested review from lhy1024 and nolouch July 28, 2021 09:18
@codecov
Copy link

codecov bot commented Jul 28, 2021 •
edited
Loading

Codecov Report

Merging #3920 (52a6583) into master (78460ca) will decrease coverage by 0.12%.
The diff coverage is 86.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3920      +/-   ##
==========================================
- Coverage   74.65%   74.53%   -0.13%     
==========================================
  Files         246      246              
  Lines       25005    25037      +32     
==========================================
- Hits        18668    18661       -7     
- Misses       4683     4712      +29     
- Partials     1654     1664      +10
Flag Coverage Δ
unittests 74.53% <86.45%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 86.15% <85.86%> (+0.15%) ⬆️
tools/pd-ctl/pdctl/command/scheduler.go 73.11% <100.00%> (+0.24%) ⬆️
server/schedulers/shuffle_hot_region.go 55.10% <0.00%> (-10.21%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/election/leadership.go 83.90% <0.00%> (-3.45%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-2.33%) ⬇️
server/member/member.go 64.70% <0.00%> (-2.14%) ⬇️
server/tso/allocator_manager.go 66.77% <0.00%> (-1.34%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78460ca...52a6583. Read the comment docs.

Yisaer added 3 commits July 28, 2021 17:34
@Yisaer
support priority
385c3f7 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support priority
de72b36 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support priority
bcd5933 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer changed the title support priority scheduler: support priority for each dimension in hot scheduling Jul 29, 2021
@Yisaer
fix test
cc20afa 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review July 29, 2021 03:48
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2021
Yisaer added 5 commits July 29, 2021 12:09
@Yisaer
address the comment
bbb214f 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
33c394a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
e36fccf 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
f44cc49 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
99e9c78 
Signed-off-by: yisaer <disxiaofei@163.com>
lhy1024
lhy1024 reviewed Jul 29, 2021
View reviewed changes
Yisaer added 2 commits July 29, 2021 18:09
@Yisaer
address the comment
cd8d0d7 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
da99aea 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2021
@Yisaer Yisaer added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 29, 2021
@Yisaer
Copy link
Contributor Author

Yisaer commented Jul 29, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: da99aea

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2021
@ti-chi-bot ti-chi-bot merged commit fa0ada7 into tikv:master Jul 29, 2021
@lhy1024 lhy1024 mentioned this pull request Jul 29, 2021
Closed
28 tasks
nolouch pushed a commit to nolouch/pd that referenced this pull request Aug 2, 2021
@Yisaer @ti-chi-bot @nolouch
scheduler: support priority for each dimension in hot scheduling (tik…
e6c8015 
…v#3920)

* support priority

Signed-off-by: yisaer <disxiaofei@163.com>

* support priority

Signed-off-by: yisaer <disxiaofei@163.com>

* support priority

Signed-off-by: yisaer <disxiaofei@163.com>

* support priority

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@lhy1024 lhy1024 mentioned this pull request Aug 4, 2021
Closed
@njuwelkin njuwelkin mentioned this pull request Jun 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yisaer @ti-chi-bot @nolouch @lhy1024