Skip to content

scheduler: fix sort hotpeer in hot scheduler #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2021
Merged

scheduler: fix sort hotpeer in hot scheduler #3741

merged 4 commits into from
Jun 4, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jun 4, 2021

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

fix sort hotpeer in hot scheduler

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
fix
01847c1 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 added the component/scheduler Scheduler logic. label Jun 4, 2021
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 4, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and rleungx June 4, 2021 03:08
rleungx
rleungx approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is not covered by our tests :(

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 4, 2021 •
edited
Loading

This section is not covered by our tests :(

I will add the test later

@lhy1024
add test
c859487 
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #3741 (318aabc) into master (16e73de) will decrease coverage by 0.21%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3741      +/-   ##
==========================================
- Coverage   75.24%   75.03%   -0.22%     
==========================================
  Files         244      244              
  Lines       24475    24477       +2     
==========================================
- Hits        18417    18366      -51     
- Misses       4461     4489      +28     
- Partials     1597     1622      +25
Flag Coverage Δ
unittests 75.03% <33.33%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 84.72% <33.33%> (+3.38%) ⬆️
server/tso/local_allocator.go 73.61% <0.00%> (-9.73%) ⬇️
server/region_syncer/server.go 83.33% <0.00%> (-6.07%) ⬇️
server/election/leadership.go 83.52% <0.00%> (-5.89%) ⬇️
server/tso/global_allocator.go 70.55% <0.00%> (-5.00%) ⬇️
server/member/member.go 68.27% <0.00%> (-4.84%) ⬇️
server/tso/allocator_manager.go 77.96% <0.00%> (-4.35%) ⬇️
client/base_client.go 82.47% <0.00%> (-2.07%) ⬇️
server/tso/tso.go 71.91% <0.00%> (-1.13%) ⬇️
server/cluster/coordinator.go 72.19% <0.00%> (-0.71%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e73de...318aabc. Read the comment docs.

nolouch
nolouch approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@nolouch
Copy link
Contributor

nolouch commented Jun 4, 2021

@lhy1024 statics failed.

rleungx
rleungx reviewed Jun 4, 2021
View reviewed changes
@lhy1024
address comment
adf6f8c 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 4, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: adf6f8c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a9e629d into tikv:master Jun 4, 2021
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
@lhy1024 @ti-chi-bot @bufferflies
scheduler: fix sort hotpeer in hot scheduler (tikv#3741)
7554b71 
* fix

Signed-off-by: lhy1024 <admin@liudos.us>

* add test

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
@lhy1024 @ti-chi-bot @bufferflies
scheduler: fix sort hotpeer in hot scheduler (tikv#3741)
8040341 
* fix

Signed-off-by: lhy1024 <admin@liudos.us>

* add test

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@nolouch nolouch mentioned this pull request Jul 13, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@rleungx rleungx rleungx approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
component/scheduler Scheduler logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhy1024 @ti-chi-bot @nolouch @rleungx