Skip to content

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 26, 2025

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 26, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 26, 2025
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2025
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-26 09:30:19.160927909 +0000 UTC m=+955271.884106891: ☑️ agreed by lhy1024.
  • 2025-06-26 09:34:31.398078206 +0000 UTC m=+955524.121257188: ☑️ agreed by okJiang.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.21%. Comparing base (a9217e7) to head (ca96519).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9450      +/-   ##
==========================================
- Coverage   76.24%   76.21%   -0.03%     
==========================================
  Files         479      479              
  Lines       75434    75466      +32     
==========================================
+ Hits        57511    57513       +2     
- Misses      14358    14393      +35     
+ Partials     3565     3560       -5     
Flag Coverage Δ
unittests 76.21% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit d45f72c into tikv:master Jun 26, 2025
26 checks passed
okJiang pushed a commit to okJiang/pd that referenced this pull request Aug 7, 2025
close tikv#4399

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okjiang <819421878@qq.com>
okJiang added a commit to okJiang/pd that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue
3 participants