Skip to content

core: optimize the score reimburse in new store #9426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2025
Merged

core: optimize the score reimburse in new store #9426

merged 2 commits into from
Jun 25, 2025

Conversation

bufferflies
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #9145

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

None.

@bufferflies
cancel the disk reimburse
42bca8c 
Signed-off-by: 童剑 <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2025
@lhy1024 lhy1024 self-requested a review June 20, 2025 02:44
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 20, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (378d78e) to head (eac94db).
Report is 24 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9426      +/-   ##
==========================================
+ Coverage   76.18%   76.27%   +0.08%     
==========================================
  Files         479      479              
  Lines       75361    75365       +4     
==========================================
+ Hits        57416    57485      +69     
+ Misses      14380    14331      -49     
+ Partials     3565     3549      -16
Flag Coverage Δ
unittests 76.27% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 24, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 24, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-20 03:51:37.519444026 +0000 UTC m=+416550.242623008: ☑️ agreed by lhy1024.
  • 2025-06-24 20:34:27.00342165 +0000 UTC m=+822319.726600653: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 145349e into tikv:master Jun 25, 2025
26 checks passed
@bufferflies bufferflies added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Jul 8, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-7.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Jul 8, 2025
@bufferflies bufferflies added type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. type/cherry-pick-for-release-9.0-beta.1 labels Jul 8, 2025
@ti-chi-bot ti-chi-bot bot removed type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. type/cherry-pick-for-release-9.0-beta.1 labels Jul 8, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-8.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-8.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-9.0-beta.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies bufferflies added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 8, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9503.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2025
Merged
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 8, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9504.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2025
Merged
@bufferflies bufferflies added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-9.0-beta.1 labels Jul 8, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9506.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2025
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-9.0-beta.1: #9507.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2025
Open
ti-chi-bot bot added a commit that referenced this pull request Jul 14, 2025
@ti-chi-bot @bufferflies @ti-chi-bot
core: optimize the score reimburse in new store (#9426) (#9504)
5e73ebb 
close #9145

Signed-off-by: 童剑 <1045931706@qq.com>

Co-authored-by: 童剑 <1045931706@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Jul 18, 2025
@ti-chi-bot @bufferflies @ti-chi-bot
core: optimize the score reimburse in new store (#9426) (#9503)
43cf21a 
close #9145

Signed-off-by: 童剑 <1045931706@qq.com>

Co-authored-by: 童剑 <1045931706@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: tongjian <1045931706@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-9.0-beta.1 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v8.5.1: scale out 3 tikvs, one tikv became stuck during region-balance
4 participants
@bufferflies @ti-chi-bot @nolouch @lhy1024