Skip to content

api: stop forwarding /ready to the leader #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

api: stop forwarding /ready to the leader #9287

merged 3 commits into from
May 6, 2025

Conversation

Tema
Copy link
Contributor

@Tema Tema commented May 4, 2025

What problem does this PR solve?

Issue Number: Close #9286

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@Tema
api: stop forwrding /ready to the leader
b19918d 
Signed-off-by: artem_danilov <artem.danilov@airbnb.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed labels May 4, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 4, 2025

Hi @Tema. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2025
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 4, 2025
@ti-chi-bot
Copy link
Member

Now you can start all CI jobs with /test all in comment or query the triggers with /test ?

@Tema
Copy link
Contributor Author

Tema commented May 4, 2025

/test ?

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 4, 2025

@Tema: The following commands are available to trigger required jobs:

/test build

/test pull-integration-realcluster-test

The following commands are available to trigger optional jobs:

/debug pull-unit-test

/test pull-integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build

tikv/pd/pull_integration_realcluster_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tema
Copy link
Contributor Author

Tema commented May 4, 2025

/retest

1 similar comment
@Tema
Copy link
Contributor Author

Tema commented May 4, 2025

/retest

@codecov Codecov
Copy link

codecov bot commented May 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (7c3b9a3) to head (e79e797).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9287      +/-   ##
==========================================
+ Coverage   75.96%   76.04%   +0.07%     
==========================================
  Files         472      472              
  Lines       73249    73257       +8     
==========================================
+ Hits        55646    55710      +64     
+ Misses      14131    14089      -42     
+ Partials     3472     3458      -14
Flag Coverage Δ
unittests 76.04% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tema Tema changed the title api: stop forwrding /ready to the leader api: stop forwarding /ready to the leader May 4, 2025
lhy1024
lhy1024 approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 6, 2025
@lhy1024
Copy link
Contributor

lhy1024 commented May 6, 2025

/check-issue-triage-complete

@Tema
add comment
9d9d0a3 
Signed-off-by: artem_danilov <artem.danilov@airbnb.com>
@Tema
Copy link
Contributor Author

Tema commented May 6, 2025

@okJiang @rleungx PTAL

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 6, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-06 02:30:41.150370079 +0000 UTC m=+322288.333273337: ☑️ agreed by lhy1024.
  • 2025-05-06 03:42:57.693230795 +0000 UTC m=+326624.876134054: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 8a19f46 into tikv:master May 6, 2025
25 checks passed
lhy1024 pushed a commit to ti-chi-bot/pd that referenced this pull request May 13, 2025
@Tema @ti-chi-bot @lhy1024
api: stop forwarding /ready to the leader (tikv#9287)
1d274a9 
close tikv#9286

Signed-off-by: artem_danilov <artem.danilov@airbnb.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 pushed a commit to lhy1024/pd that referenced this pull request May 13, 2025
@Tema @ti-chi-bot @lhy1024
api: stop forwarding /ready to the leader (tikv#9287)
8dfceac 
close tikv#9286

Signed-off-by: artem_danilov <artem.danilov@airbnb.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/ready API should never be forwarded to the leader
4 participants
@Tema @ti-chi-bot @lhy1024 @rleungx