Skip to content

tso: fix tso proxy error propagation and add test (#9219) #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

tso: fix tso proxy error propagation and add test (#9219) #9264

merged 2 commits into from
Jul 23, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9219

What problem does this PR solve?

Issue Number: Close #9188

What is changed and how does it work?

The change fixes the problems outlined in #9188 (comment)

  • Don't block client stream on receiving next request and allow to return error from proxy
  • Allow to return proxy error to all clients served by the proxy error
  • Don't cancel proxy stream after original client stream is closed

Tested using the same way as reported in the issue and observe subsecond impact only now:

[ 67s ] thds: 64 tps: 2007.63 qps: 2007.63 (r/w/o: 0.00/2007.63/0.00) lat (ms,95%): 116.80 err/s: 0.00 reconn/s: 0.00
[ 68s ] thds: 64 tps: 1962.21 qps: 1962.21 (r/w/o: 0.00/1962.21/0.00) lat (ms,95%): 121.08 err/s: 0.00 reconn/s: 0.00
[ 69s ] thds: 64 tps: 1984.16 qps: 1984.16 (r/w/o: 0.00/1984.16/0.00) lat (ms,95%): 116.80 err/s: 0.00 reconn/s: 0.00
[ 70s ] thds: 64 tps: 504.00 qps: 504.00 (r/w/o: 0.00/504.00/0.00) lat (ms,95%): 646.19 err/s: 0.00 reconn/s: 0.00
[ 71s ] thds: 64 tps: 1607.99 qps: 1607.99 (r/w/o: 0.00/1607.99/0.00) lat (ms,95%): 125.52 err/s: 0.00 reconn/s: 0.00
[ 72s ] thds: 64 tps: 2010.98 qps: 2010.98 (r/w/o: 0.00/2010.98/0.00) lat (ms,95%): 116.80 err/s: 0.00 reconn/s: 0.00
[ 73s ] thds: 64 tps: 1965.68 qps: 1965.68 (r/w/o: 0.00/1965.68/0.00) lat (ms,95%): 123.28 err/s: 0.00 reconn/s: 0.00

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 25, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 25, 2025
Merged
@purelind
Copy link
Contributor

/retest

1 similar comment
@purelind
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2025 •
edited
Loading

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci/build 38cf08c link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 7, 2025
@Tema @JmPotato
This is an automated cherry-pick of tikv#9219
bc1a90b 
close tikv#9188

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato force-pushed the cherry-pick-9219-to-release-7.5 branch from 38cf08c to bc1a90b Compare July 23, 2025 05:10
JmPotato added a commit to ti-chi-bot/pd that referenced this pull request Jul 23, 2025
@JmPotato
Merge tikv#9264
da35b23 
Signed-off-by: JmPotato <github@ipotato.me>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2025
@JmPotato
Merge tikv#9495
19c96da 
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato force-pushed the cherry-pick-9219-to-release-7.5 branch from da35b23 to 19c96da Compare July 23, 2025 05:20
@JmPotato JmPotato mentioned this pull request Jul 23, 2025
Closed
@JmPotato JmPotato changed the title tso: fix tso proxy error propagation (#9219) tso: fix tso proxy error propagation and add test (#9219) Jul 23, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 23, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 23, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-23 06:25:06.036335099 +0000 UTC m=+145862.773761495: ☑️ agreed by rleungx.
  • 2025-07-23 06:58:26.755894871 +0000 UTC m=+147863.493321079: ☑️ agreed by JmPotato.

@JmPotato JmPotato removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit ca4dd11 into tikv:release-7.5 Jul 23, 2025
47 of 49 checks passed
@JmPotato JmPotato deleted the cherry-pick-9219-to-release-7.5 branch July 23, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @purelind @JmPotato @rleungx @Tema